[powershell] vcpkg doesn't work with PowerShell installed from Windows Store.

[zomgrolf]

Describe the bug
It seems that vcpkg doesn't work with the version of PowerShell Core installed from the Windows Store. The initial check seems to pass and vcpkg doesn't download its local copy, but vcpkg_copy_tool_dependencies issues an error when trying to build a port that uses Powershell.

Environment

• OS: Windows 10 Pro 20H2
• Compiler: 19.28.29914 (VS 2019 16.9.4)

To Reproduce
Steps to reproduce the behavior:

1. Install Powershell from the Windows Store (version 7.1.3)
2. Sync the vcpkg repo (e.g. to c:/tools/vcpkg); run bootstrap-vcpkg.bat
3. In a directory of your choice set the following environment variables

set VCPKG_TOOLCHAIN_FILE=C:/tools/vcpkg/scripts/buildsystems/vcpkg.cmake
set VCPKG_FEATURE_FLAGS=manifests,versions
set VCPKG_MANIFEST_DIR=%~dp0

And edit the vcpkg.json file:

{
    "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json",
    "name": "brotli-test",
    "version": "0.0.1",
    "builtin-baseline": "5a10163c44526b5d42a67480ce7a692a36948761",
    "dependencies": [
        "brotli"
    ]
}

4. run vcpkg install --binarysource=clear

Expected behavior
Build succeeding

Failure logs

Detecting compiler hash for triplet x86-windows...
The following packages will be built and installed:
    brotli[core]:x86-windows -> 1.0.9#1 -- C:\tools\vcpkg\buildtrees\versioning\versions\brotli\8f55fe158d8bd753a6e6908164e03ae4f0b73cea
Starting package 1/1: brotli:x86-windows
Building package brotli[core]:x86-windows...
-- Installing port from location: C:\tools\vcpkg\buildtrees\versioning\versions\brotli\8f55fe158d8bd753a6e6908164e03ae4f0b73cea
-- Downloading https://github.com/google/brotli/archive/e61745a6b7add50d380cfd7d3883dd6c62fc2c71.tar.gz -> google-brotli-e61745a6b7add50d380cfd7d3883dd6c62fc2c71.tar.gz...
-- Extracting source C:/tools/vcpkg/downloads/google-brotli-e61745a6b7add50d380cfd7d3883dd6c62fc2c71.tar.gz
-- Applying patch install.patch
-- Applying patch fix-arm-uwp.patch
-- Applying patch pkgconfig.patch
-- Applying patch fix-ios.patch
-- Using source at C:/tools/vcpkg/buildtrees/brotli/src/6c62fc2c71-f2afd323e3.clean
-- Found external ninja('1.10.2').
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
CMake Error at scripts/cmake/vcpkg_copy_tool_dependencies.cmake:29 (message):
  Could not find PowerShell Core; please open an issue to report this.
Call Stack (most recent call first):
  buildtrees/versioning/versions/brotli/8f55fe158d8bd753a6e6908164e03ae4f0b73cea/portfile.cmake:24 (vcpkg_copy_tool_dependencies)
  scripts/ports.cmake:142 (include)


Error: Building package brotli:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: brotli:x86-windows
  Vcpkg version: 2021-01-13-d67989bce1043b98092ac45996a8230a059a2d7e

Additionally, attach any relevant sections from the log files above.

Additional context
where pwsh.exe issued in the same command prompt prints out: c:\Users\zomgrolf\AppData\Local\Microsoft\WindowsApps\pwsh.exe

Running vcpkg with the --debug flag produces this:

[DEBUG] Found path: c:\users\zomgrolf\AppData\Local\Microsoft\WindowsApps\pwsh.exe
[DEBUG] Found path: C:\Users\zomgrolf\AppData\Local\Microsoft\WindowsApps\pwsh.exe
[DEBUG] CreateProcessW("c:\users\zomgrolf\AppData\Local\Microsoft\WindowsApps\pwsh.exe" --version)
[DEBUG] cmd_execute_and_stream_data() returned 0 after   330190 us

There is no copy of PowerShell-7.1.0-win-x86.zip in c:/tools/vcpkg/downloads

If I replace the version from Windows Store with a version installed from the *.msi installer the build succeeds. It seems that CMake is unable to find the Windows Store version of PowerShell?

[JackBoosY]

Did you use powershell or cmd?

[zomgrolf]

cmd

[JackBoosY]

@zomgrolf Please use powershell instead.
Ignore my nonsense.

[zomgrolf]

You have to be joking.

[JackBoosY]

@zomgrolf Forgive me... I didn't understand clearly.

[JackBoosY]

@strega-nil Can you please take a look? I think this is a bug of vcpkg.

[zomgrolf]

My guess is it's an issue with CMake (or CMake scripts used by vcpkg?). The method vcpkg uses to test if there's a suitable version of PowerShell available seems to succeed (as expected), however the call to find_program(PWSH_EXE pwsh) in vcpkg_copy_tool_dependencies.cmake fails (unexpectedly).
I would expect that call to succeed, not sure why it doesn't. I've just tried this simple CMake script in a separate command prompt:

cmake_minimum_required(VERSION 3.19)

project(TEST)

find_program(PWSH_EXE pwsh)
if (NOT PWSH_EXE)
    message(FATAL_ERROR "Could not find PowerShell Core; please open an issue to report this.")
endif()

add_executable(test test.cpp)

And it fails with the Windows Store version of PowerShell Core. However, CMake clearly is the lowest common denominator here -- so until this is fixed, I would suggest making vcpkg a bit more eager to download a local copy of PowerShell.