[vcpkg upgrade] No different source warning on upgrade

[OlafvdSpek]

The first upgrade command didn't warn about the difference source issue.. IMO it should have.

PS C:\vc\vcpkg> ./vcpkg upgrade
Error: cannot locate new portfile for openssl:x86-windows. Please explicitly remove this package with `vcpkg remove openssl:x86-windows`.

PS C:\vc\vcpkg> ./vcpkg remove openssl
Warning: Different source is available for vcpkg (2018.11.23 -> 2019.6.21). Use .\bootstrap-vcpkg.bat to update.
The following packages will be removed:
  * boost-asio:x86-windows
    openssl:x86-windows
Additional packages (*) need to be removed to complete this operation.
If you are sure you want to remove them, run the command with the --recurse option

PS C:\vc\vcpkg> .\bootstrap-vcpkg.bat

Building vcpkg.exe ...

  pch.cpp
  ...
  visualstudio.cpp
  vcpkglib.vcxproj -> C:\vc\vcpkg\toolsrc\msbuild.x86.release\vcpkglib.lib
  vcpkg.cpp
  Generating code
  Previous IPDB not found, fall back to full compilation.
  All 15099 functions were compiled because no usable IPDB/IOBJ from previous compilation was found.
  Finished generating code
  vcpkg.vcxproj -> C:\vc\vcpkg\toolsrc\msbuild.x86.release\vcpkg.exe
  vcpkgmetricsuploader.cpp
  Generating code
  Previous IPDB not found, fall back to full compilation.
  All 4956 functions were compiled because no usable IPDB/IOBJ from previous compilation was found.
  Finished generating code
  vcpkgmetricsuploader.vcxproj -> C:\vc\vcpkg\toolsrc\msbuild.x86.release\vcpkgmetricsuploader.exe

Building vcpkg.exe... done.

PS C:\vc\vcpkg> ./vcpkg upgrade
The following packages will be rebuilt:
  * boost-asio[core]:x86-windows
  * boost-convert[core]:x86-windows
  * boost-spirit[core]:x86-windows
    boost-variant[core]:x86-windows
    curl[core,ssl,winssl]:x86-windows
    libogg[core]:x86-windows
    libpng[core]:x86-windows
    libsodium[core]:x86-windows
  * libvorbis[core]:x86-windows
    openssl[core]:x86-windows
    openssl-windows[core]:x86-windows
Additional packages (*) will be modified to complete this operation.
If you are sure you want to rebuild the above packages, run this command with the --no-dry-run option.

[OlafvdSpek]

Starting package 5/8: boost-asio:x86-windows
Building package boost-asio[core]:x86-windows...
Unknown variable name VCPKG_ENV_PASSTHROUGH=

A run of bootstrap-vcpkg.bat fixes it.

[degski]

@OlafvdSpek Yes, found the same (problem and solution). We really should have auto-bootstrapping, I filed an issue #7328.

[heydojo]

On a side note, Interesting to see x86-windows and not x64-windows.

And it might be helpful to test out updates by cloning into a new folder from master, boot strapping that and then compiling against it before you migrate to the latest version. That way you can slowly migrate and fix any issues introduced by newer versions of software your application may be dependant upon which vcpkg provides. Disc space obviously needs not be at a premium.

I will also add that testing updates in that way enables you to maintain any changes which you have to make to the vcpkg tree but cannot commit back upstream for whatever reason.

Some of us who use vcpkg cannot contribute code back to vcpkg via code commits due to the licensing agreement Microsoft requires you to sign.
Therefore we all maintain our own separate forks which is creating quite the fragmentation. But I digress.
I have personally never used the upgrade feature and always rebase. Mostly because I'm lazy and intolerant of things which break thus I will not entertain work I neither have the desire nor the time to complete. You shouldn't either IMO.

[cbezault]

@heydojo It's interesting that you can't contribute some of your vcpkg code to because of the CLA, could you explain in more detail why? I have no problem bringing it up with legal.

@OlafvdSpek Your complaint that upgrade should have detected the changes to the vcpkg source is valid, as I stated in #7328 that was partly my fault. We're trying to move away from manually maintained versions and to use source file hashes much more extensively.

[OlafvdSpek]

@cbezault I don't think that's it.. as the second vcpkg cmd did detect the need to bootstrap.

[cbezault]

Huh, okay I misread that, point well taken.

[OlafvdSpek]

How's progress on this one?

[OlafvdSpek]

Today I hit:

Elapsed time for package boost-locale:x86-windows: 41.75 ms
Detecting compiler hash for triplet x86-windows...
Could not automatically acquire pwsh because there is no entry in C:\VC\vcpkg\scripts\vcpkgTools.xml for os=windows. You may be able to install pwsh via your system package manager.