Merge pull request #649 from drewnoakes/fix-VSMEF003

Fix exception in VSMEF003 relating to unbound generic interfaces

Author: AArnott

src/Microsoft.VisualStudio.Composition.Analyzers/VSMEF003ExportTypeMismatchAnalyzer.cs

@@ -155,7 +155,26 @@ private static bool IsTypeCompatible(INamedTypeSymbol implementingType, INamedTy
         // Check if implementing type implements exported interface
         if (exportedType.TypeKind == TypeKind.Interface)
         {
-            return implementingType.AllInterfaces.Any(i => SymbolEqualityComparer.Default.Equals(exportedType.IsUnboundGenericType ? i.ConstructUnboundGenericType() : i, exportedType));
+            foreach (INamedTypeSymbol iface in implementingType.AllInterfaces)
+            {
+                if (exportedType.IsUnboundGenericType)
+                {
+                    if (iface is INamedTypeSymbol { IsGenericType: true } namedInterface)
+                    {
+                        if (SymbolEqualityComparer.Default.Equals(namedInterface.ConstructUnboundGenericType(), exportedType))
+                        {
+                            return true;
+                        }
+                    }
+                }
+                else
+                {
+                    if (SymbolEqualityComparer.Default.Equals(iface, exportedType))
+                    {
+                        return true;
+                    }
+                }
+            }
         }
 
         return false;

test/Microsoft.VisualStudio.Composition.Analyzers.Tests/VSMEF003ExportTypeMismatchAnalyzerTests.cs

@@ -421,4 +421,34 @@ class TestClass
 
         await VerifyCS.VerifyAnalyzerAsync(test);
     }
+
+    [Fact]
+    public async Task ExportingWrongUnboundGenericWithNonGenericInterfaces_ForcesEvaluationOfAllInterfaces()
+    {
+        // Reproduces a bug seen related to unbound generic types.
+        string test = """
+            using System;
+            using System.Composition;
+
+            interface IValue<T>
+            {
+            }
+
+            interface IOther<T>
+            {
+            }
+
+            interface IFirstInterface
+            {
+            }
+
+            [Export(typeof(IOther<>))]
+            class [|Test|]<T> : IValue<T>, IFirstInterface, IDisposable
+            {
+                public void Dispose() => throw new NotImplementedException();
+            }
+            """;
+
+        await VerifyCS.VerifyAnalyzerAsync(test);
+    }
 }