Skip to content

Commit c2975e7

Browse files
sean-mcmanussean-mcmanus
authored
Merge pull request #12731 from microsoft/main
Merge to vs
2 parents 67cf965 + 970f95b commit c2975e7

File tree

110 files changed

+642
-1880
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

110 files changed

+642
-1880
lines changed

Diff for: ‎.github/actions/AddComment/AddComment.js

+16
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎.github/actions/AddComment/AddComment.ts

+18-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { daysAgoToHumanReadbleDate, daysAgoToTimestamp, safeLog } from '../commo
1010
export class AddComment extends ActionBase {
1111
constructor(
1212
private github: GitHub,
13-
private createdAfter: string,
13+
private createdAfter: string | undefined,
1414
private afterDays: number,
1515
labels: string,
1616
private addComment: string,
@@ -45,6 +45,23 @@ export class AddComment extends ActionBase {
4545
if (hydrated.open && this.validateIssue(hydrated)
4646
// TODO: Verify updated timestamp
4747
) {
48+
// Don't add a comment if already commented on by an action.
49+
let foundActionComment = false;
50+
for await (const commentBatch of issue.getComments()) {
51+
for (const comment of commentBatch) {
52+
if (comment.author.isGitHubApp) {
53+
foundActionComment = true;
54+
break;
55+
}
56+
}
57+
if (foundActionComment)
58+
break;
59+
}
60+
if (foundActionComment) {
61+
safeLog(`Issue ${hydrated.number} already commented on by an action. Ignoring.`);
62+
continue;
63+
}
64+
4865
if (this.addComment) {
4966
safeLog(`Posting comment on issue ${hydrated.number}`);
5067
await issue.postComment(this.addComment);

Diff for: ‎.github/workflows/bug-debugger.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Bug - debugger
22
on:
33
schedule:
4-
- cron: 20 11 * * * # Run at 11:20 AM UTC (3:20 AM PST, 4:20 AM PDT)
4+
- cron: 50 12 * * * # Run at 12:50 PM UTC (4:50 AM PST, 5:50 AM PDT)
55
workflow_dispatch:
66
inputs:
77
readonly:

Diff for: ‎.github/workflows/by-design-closer-debugger .yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: By Design closer - debugger
22
on:
33
schedule:
4-
- cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
4+
- cron: 0 13 * * * # Run at 1:00 PM UTC (5:00 AM PST, 6:00 AM PDT)
55
workflow_dispatch:
66
inputs:
77
readonly:

Diff for: ‎.github/workflows/enhancement-closer-no-milestone.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Enhancement Closer (no milestone)
22
on:
33
schedule:
4-
- cron: 50 11 * * * # Run at 11:50 AM UTC (3:50 AM PST, 4:50 AM PDT)
4+
- cron: 40 12 * * * # Run at 12:40 PM UTC (4:40 AM PST, 5:40 AM PDT)
55
workflow_dispatch:
66
inputs:
77
readonly:

Diff for: ‎.github/workflows/enhancement-closer-triage.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Enhancement Closer (Triage)
22
on:
33
schedule:
4-
- cron: 40 11 * * * # Run at 11:40 AM UTC (3:40 AM PST, 4:40 AM PDT)
4+
- cron: 30 12 * * * # Run at 12:30 PM UTC (4:30 AM PST, 5:30 AM PDT)
55
workflow_dispatch:
66
inputs:
77
readonly:

Diff for: ‎.github/workflows/enhancement-reopener.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Enhancement Reopener
22
on:
33
schedule:
4-
- cron: 20 12 * * * # Run at 12:20 PM UTC (4:20 AM PST, 5:20 AM PDT)
4+
- cron: 0 11 * * * # Run at 11:00 AM UTC (3:00 AM PST, 4:00 AM PDT)
55
workflow_dispatch:
66
inputs:
77
readonly:

Diff for: ‎.github/workflows/external-closer-debugger.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: External closer - debugger
22
on:
33
schedule:
4-
- cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
4+
- cron: 10 13 * * * # Run at 1:10 PM UTC (5:10 AM PST, 6:10 AM PDT)
55
workflow_dispatch:
66
inputs:
77
readonly:

Diff for: ‎.github/workflows/feature-request-debugger.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Feature Request - debugger
22
on:
33
schedule:
4-
- cron: 20 11 * * * # Run at 11:20 AM UTC (3:20 AM PST, 4:20 AM PDT)
4+
- cron: 20 13 * * * # Run at 1:20 PM UTC (5:20 AM PST, 6:20 AM PDT)
55
workflow_dispatch:
66
inputs:
77
readonly:

Diff for: ‎.github/workflows/investigate-closer-debugger.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Investigate closer - debugger
22
on:
33
schedule:
4-
- cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
4+
- cron: 30 13 * * * # Run at 1:30 PM UTC (5:30 AM PST, 6:30 AM PDT)
55
workflow_dispatch:
66
inputs:
77
readonly:

Diff for: ‎.github/workflows/investigate-costing-closer-debugger.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Investigate Costing closer - debugger
22
on:
33
schedule:
4-
- cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
4+
- cron: 40 13 * * * # Run at 1:40 PM UTC (5:40 AM PST, 6:40 AM PDT)
55
workflow_dispatch:
66
inputs:
77
readonly:

Diff for: ‎.github/workflows/more-info-needed-closer-debugger.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: More Info Needed Closer - debugger
22
on:
33
schedule:
4-
- cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
4+
- cron: 50 13 * * * # Run at 1:50 PM UTC (5:50 AM PST, 6:50 AM PDT)
55
workflow_dispatch:
66
inputs:
77
readonly:

Diff for: ‎.github/workflows/question-closer-debugger.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Question Closer - debugger
22
on:
33
schedule:
4-
- cron: 20 11 * * * # Run at 11:20 AM UTC (3:20 AM PST, 4:20 AM PDT)
4+
- cron: 0 14 * * * # Run at 2:00 PM UTC (6:00 AM PST, 7:00 AM PDT)
55
workflow_dispatch:
66
inputs:
77
readonly:

Diff for: ‎Extension/.scripts/common.ts

+1
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ export async function checkDTS() {
325325
let failing = false;
326326
failing = !await assertAnyFile('vscode.d.ts') && (quiet || warn(`The VSCode import file '${$root}/dist/src/vscode.d.ts is missing.`)) || failing;
327327
failing = !await assertAnyFile('vscode.proposed.terminalDataWriteEvent.d.ts') && (quiet || warn(`The VSCode import file '${$root}/dist/src/vscode.proposed.terminalDataWriteEvent.d.ts is missing.`)) || failing;
328+
failing = !await assertAnyFile('vscode.proposed.lmTools.d.ts') && (quiet || warn(`The VSCode import file '${$root}/dist/src/vscode.proposed.lmTools.d.ts is missing.`)) || failing;
328329

329330
if (!failing) {
330331
verbose('VSCode d.ts files appear to be in place.');

Diff for: ‎Extension/.vscode/settings.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
},
3838
"[typescript]": {
3939
"editor.tabSize": 4,
40-
"editor.defaultFormatter": "dbaeumer.vscode-eslint",
40+
"editor.defaultFormatter": "vscode.typescript-language-features",
4141
"editor.formatOnSave": true,
4242
"files.insertFinalNewline": true,
4343
"editor.codeActionsOnSave": {

Diff for: ‎Extension/CHANGELOG.md

+41-2
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,52 @@
11
# C/C++ for Visual Studio Code Changelog
22

3-
## Version 1.22.0: August 21, 2024
3+
## Version 1.22.3: September 12, 2024
4+
### Enhancement
5+
* Add support for providing additional context information to Copilot Chat. [PR #12685](https://github.com/microsoft/vscode-cpptools/pull/12685)
6+
* Currently, it requires `"C_Cpp.experimentalFeatures": "enabled"` and typing `#cpp` in the chat.
7+
8+
### Bug Fixes
9+
* Fix the compiler selection control not keeping the list in sync with contents of the textbox. [#7427](https://github.com/microsoft/vscode-cpptools/issues/7427)
10+
* Fix a string localization issue. [#7824](https://github.com/microsoft/vscode-cpptools/issues/7824)
11+
* Stop logging duplicate compiler path messages. [#12445](https://github.com/microsoft/vscode-cpptools/issues/12445)
12+
* Fix some crashes with recursive includes. [#12643](https://github.com/microsoft/vscode-cpptools/issues/12643)
13+
* Fix a rare crash on macOS related to `get_memory_usage`. [#12667](https://github.com/microsoft/vscode-cpptools/issues/12667)
14+
* Fix an issue with 'Extract to Function' formatting. [#12677](https://github.com/microsoft/vscode-cpptools/issues/12677)
15+
* Fix a potential deadlock in `process_paths`. [#12690](https://github.com/microsoft/vscode-cpptools/issues/12690)
16+
17+
## Version 1.22.2: August 29, 2024
18+
### Enhancement
19+
* Remove the `C_Cpp.intelliSenseEngineFallback` setting. [#12596](https://github.com/microsoft/vscode-cpptools/issues/12596)
20+
21+
### Bug Fix
22+
* Fix a deadlock when doing "Find All References" and a file is deleted. [#12656](https://github.com/microsoft/vscode-cpptools/issues/12656)
23+
24+
## Version 1.22.1: August 29, 2024
25+
### Enhancement
26+
* Add "Additional Tracked Settings" to `C/C++: Log Diagnostics` output. [PR #12635](https://github.com/microsoft/vscode-cpptools/pull/12635)
27+
28+
### Bug Fixes
29+
* Fix hover over static constexpr variables sometimes not working. [#12284](https://github.com/microsoft/vscode-cpptools/issues/12284)
30+
* Fix completion not giving results in several scenarios. [#12412](https://github.com/microsoft/vscode-cpptools/issues/12412)
31+
* Fix include completion showing results for deleted folders with recursive includes. [#12636](https://github.com/microsoft/vscode-cpptools/issues/12636)
32+
* Fix the `/FU` flag not working for C++/CLI . [#12641](https://github.com/microsoft/vscode-cpptools/issues/12641)
33+
* Fix some crashes with recursive includes. [#12643](https://github.com/microsoft/vscode-cpptools/issues/12643)
34+
* Fix IntelliSense not working on Windows when `C_Cpp.caseSensitiveFileSupport` is `enabled`. [#12648](https://github.com/microsoft/vscode-cpptools/issues/12648)
35+
* Changes that might fix a crash with `translate_encoding_to_utf8`. [#12652](https://github.com/microsoft/vscode-cpptools/issues/12652)
36+
* Fix a random crash during IntelliSense creation.
37+
38+
## Version 1.22.0: August 26, 2024
439
### Performance Improvements
540
* Switch to an alternative implementation of recursive includes (that sends all the paths instead of only the "used" paths). [#11780](https://github.com/microsoft/vscode-cpptools/issues/11780)
641
- Performance improvement: Configuration is no longer blocked on tag parsing of all dependent headers.
7-
- Configuration change: Recursive include paths now always take precedence over system include paths (similar to compiler behavior and non-recursive includes). [#11485](https://github.com/microsoft/vscode-cpptools/issues/11485)
42+
- Configuration change: Recursive include paths now take precedence over system include paths (similar to compiler behavior and non-recursive includes). [#11485](https://github.com/microsoft/vscode-cpptools/issues/11485)
843
* Initialization performance improvements. [#12030](https://github.com/microsoft/vscode-cpptools/issues/12030)
944
- Some processing is parallelized and started earlier (populating the filename cache, discovering files). [#11954](https://github.com/microsoft/vscode-cpptools/issues/11954), [#12169](https://github.com/microsoft/vscode-cpptools/issues/12169)
1045
- Some compiler configuration queries are cached in the database, and processing of compile_commands.json was improved. [#10029](https://github.com/microsoft/vscode-cpptools/issues/10029), [#12078](https://github.com/microsoft/vscode-cpptools/issues/12078)
1146
* Improve the implementation of file buffers to reduce memory usage.
1247

1348
### Enhancements
49+
* Add modified `C_Cpp` settings to the `C/C++: Log Diagnostics` output. [#11700](https://github.com/microsoft/vscode-cpptools/issues/11700)
1450
* Change the default C/C++ `"editor.stickyScroll.defaultModel"` to `"foldingProviderModel"`. [#12483](https://github.com/microsoft/vscode-cpptools/issues/12483)
1551
* Add better validation for settings. [#12371](https://github.com/microsoft/vscode-cpptools/issues/12371)
1652
* Various IntelliSense parsing updates/fixes.
@@ -20,13 +56,16 @@
2056
* Fix an issue where a file is incorrectly processed as C instead of C++. [#12466](https://github.com/microsoft/vscode-cpptools/issues/12466)
2157
* Fix include path ordering being incorrect if there is a duplicate. [#12525](https://github.com/microsoft/vscode-cpptools/issues/12525)
2258
* Fix a WebAssembly "Out of Memory" error. [#12529](https://github.com/microsoft/vscode-cpptools/issues/12529)
59+
* Fix an error message not being shown if the connection failed with remote attach debugging. [#12547](https://github.com/microsoft/vscode-cpptools/issues/12547)
60+
* Thank you for the contribution. [@MrStanislav0 (Stanislav)](https://github.com/MrStanislav0)
2361
* Fix `-I` not being used if `-iquote` is also used for the same path. [#12551](https://github.com/microsoft/vscode-cpptools/issues/12551)
2462
* Fix issues with relative paths on `nvcc` (CUDA) command lines not being handled correctly. [#12553](https://github.com/microsoft/vscode-cpptools/issues/12553)
2563
* Fix a random crash when a child process is created. [#12585](https://github.com/microsoft/vscode-cpptools/issues/12585)
2664
* Fix a crash on shutdown on macOS with a verbose logging level. [#12567](https://github.com/microsoft/vscode-cpptools/issues/12567)
2765
* Fix some issues with recursive includes handling of symbolic links, multi-root, exclusion changes, and file/folder deletion.
2866
* Fix unnecessary IntelliSense resetting when a new file or folder was created.
2967
* Fix accumulation of stale signature help and completion requests.
68+
* Fix some bugs with include completion.
3069

3170
## Version 1.21.6: August 5, 2024
3271
* Fix a cpptools-srv crash on shutdown. [#12354](https://github.com/microsoft/vscode-cpptools/issues/12354)

Diff for: ‎Extension/bin/messages/cs/messages.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -1410,7 +1410,7 @@
14101410
"Striktní režim je nekompatibilní se zpracováním oboru názvů std jako aliasu pro globální obor názvů.",
14111411
"v rozšíření makra %s %p",
14121412
"<NEZNÁMÝ>",
1413-
"",
1413+
null,
14141414
"[rozšíření makra %d není zobrazené]",
14151415
"v rozšíření makra v %p",
14161416
"neplatný název symbolického operandu %sq",
@@ -1505,7 +1505,7 @@
15051505
"Chyba příkazového řádku",
15061506
"vnitřní chyba",
15071507
"Vnitřní chyba",
1508-
null,
1508+
"-D",
15091509
null,
15101510
"Došlo k dosažení limitu chyb.",
15111511
"Smyčka interní chyby",
@@ -1524,7 +1524,7 @@
15241524
"převodní jazyk (7)",
15251525
"převodní jazyk (8)",
15261526
"převodní jazyk (9)",
1527-
null,
1527+
"PCH",
15281528
null,
15291529
null,
15301530
null,
@@ -1537,7 +1537,7 @@
15371537
"neplatný znak pro literál char16_t",
15381538
null,
15391539
"Nerozpoznaná konvence volání %s, musí být jednou z:",
1540-
null,
1540+
"%s",
15411541
null,
15421542
null,
15431543
"Nadřízený typ typu výčtu musí být integrální typ.",
@@ -2953,9 +2953,9 @@
29532953
"Neplatná hodnota sady pragma %s pro funkci s omezením AMP",
29542954
"Překrývající se specifikátory omezení nejsou povolené.",
29552955
"Specifikátory omezení destruktoru musejí pokrývat sjednocení specifikátorů omezení všech konstruktorů.",
2956-
"<error>",
2956+
"error",
29572957
"Pro nostdlib se vyžaduje aspoň jedno nucené použití.",
2958-
"<error-type>",
2958+
"error-type",
29592959
null,
29602960
null,
29612961
null,

Diff for: ‎Extension/bin/messages/de/messages.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -1410,7 +1410,7 @@
14101410
"Der Strict-Modus ist mit dem Behandeln des Namespaces \"std\" als Alias für den globalen Namespace inkompatibel.",
14111411
"In Erweiterung von Makro \"%s\" %p",
14121412
"<UNBEKANNT>",
1413-
"",
1413+
null,
14141414
"[%d Makroerweiterungen werden nicht angezeigt.]",
14151415
"In Makroerweiterung bei %p",
14161416
"Ungültiger symbolischer Operandname \"%sq\".",
@@ -1505,7 +1505,7 @@
15051505
"Befehlszeilenfehler",
15061506
"Interner Fehler.",
15071507
"Interner Fehler.",
1508-
null,
1508+
"-D",
15091509
null,
15101510
"Fehlerlimit erreicht.",
15111511
"Interne Fehlerschleife",
@@ -1524,7 +1524,7 @@
15241524
"Zwischensprache (7)",
15251525
"Zwischensprache (8)",
15261526
"Zwischensprache (9)",
1527-
null,
1527+
"PCH",
15281528
null,
15291529
null,
15301530
null,
@@ -1537,7 +1537,7 @@
15371537
"Ungültiges Zeichen für char16_t-Literal.",
15381538
null,
15391539
"Unbekannte Aufrufkonvention \"%s\", muss eine der folgenden Optionen sein:",
1540-
null,
1540+
"%s",
15411541
null,
15421542
null,
15431543
"Der zugrunde liegende Typ des Enumerationstyps muss ein integraler Typ sein.",
@@ -2953,9 +2953,9 @@
29532953
"Unzulässiger Wert für Pragmapaket \"%s\" für die auf AMP begrenzte Funktion.",
29542954
"Überlappende Einschränkungsspezifizierer sind unzulässig.",
29552955
"Die Einschränkungsspezifizierer des Destruktors müssen die Union der Einschränkungsspezifizierer für alle Konstruktoren abdecken.",
2956-
"<error>",
2956+
"Fehler",
29572957
"Für \"nostdlib\" ist mindestens eine erzwungene Verwendung erforderlich.",
2958-
"<error-type>",
2958+
"Fehlertyp",
29592959
null,
29602960
null,
29612961
null,

Diff for: ‎Extension/bin/messages/es/messages.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -1410,7 +1410,7 @@
14101410
"el modo strict no es compatible con el trato del espacio de nombres std como alias para el espacio de nombres global",
14111411
"en la expansión de macro '%s' %p,",
14121412
"<DESCONOCIDO>",
1413-
"",
1413+
null,
14141414
"[ las expansiones de macro %d no se muestran ]",
14151415
"en expansión de macro en %p",
14161416
"nombre de operando simbólico %sq no válido",
@@ -1505,7 +1505,7 @@
15051505
"Error de la línea de comandos",
15061506
"Error interno",
15071507
"Error interno",
1508-
null,
1508+
"-D",
15091509
null,
15101510
"Se ha alcanzado el límite de error.",
15111511
"Bucle de error interno",
@@ -1524,7 +1524,7 @@
15241524
"lenguaje intermedio (7)",
15251525
"lenguaje intermedio (8)",
15261526
"lenguaje intermedio (9)",
1527-
null,
1527+
"PCH",
15281528
null,
15291529
null,
15301530
null,
@@ -1537,7 +1537,7 @@
15371537
"carácter no válido para el literal char16_t",
15381538
null,
15391539
"convención de llamada %s no reconocida, debe ser una de las siguientes:",
1540-
null,
1540+
"%s",
15411541
null,
15421542
null,
15431543
"el tipo subyacente del tipo de enumeración debe ser un tipo entero",
@@ -2953,9 +2953,9 @@
29532953
"valor de pragma pack %s no válido para la función con restricción amp",
29542954
"no se permiten especificadores de restricción superpuestos",
29552955
"los especificadores de restricción del destructor deben cubrir la unión de los especificadores de restricción de todos los constructores",
2956-
"<error>",
2956+
"error",
29572957
"nostdlib requiere al menos un uso forzado",
2958-
"<error-type>",
2958+
"error-type",
29592959
null,
29602960
null,
29612961
null,

0 commit comments

Comments
 (0)