Prevent redundant progressive squiggle updates (#12876)

Colengms · web-flow · commit e58e96369f7b · 2024-10-22T15:31:38.000-07:00
diff --git a/Extension/src/LanguageServer/client.ts b/Extension/src/LanguageServer/client.ts
@@ -2387,7 +2387,9 @@ export class DefaultClient implements Client {
         }
 
         this.updateInactiveRegions(intelliSenseResult.uri, intelliSenseResult.inactiveRegions, intelliSenseResult.clearExistingInactiveRegions, intelliSenseResult.isCompletePass);
-        this.updateSquiggles(intelliSenseResult.uri, intelliSenseResult.diagnostics, intelliSenseResult.clearExistingDiagnostics);
+        if (intelliSenseResult.clearExistingDiagnostics || intelliSenseResult.diagnostics.length > 0) {
+            this.updateSquiggles(intelliSenseResult.uri, intelliSenseResult.diagnostics, intelliSenseResult.clearExistingDiagnostics);
+        }
     }
 
     private updateSquiggles(uriString: string, diagnostics: IntelliSenseDiagnostic[], startNewSet: boolean): void {

Original file line number	Diff line number	Diff line change
`@@ -2387,7 +2387,9 @@ export class DefaultClient implements Client {`
`2387`	`2387`	`}`
`2388`	`2388`
`2389`	`2389`	`this.updateInactiveRegions(intelliSenseResult.uri, intelliSenseResult.inactiveRegions, intelliSenseResult.clearExistingInactiveRegions, intelliSenseResult.isCompletePass);`
`2390`		`- this.updateSquiggles(intelliSenseResult.uri, intelliSenseResult.diagnostics, intelliSenseResult.clearExistingDiagnostics);`
	`2390`	`+ if (intelliSenseResult.clearExistingDiagnostics \|\| intelliSenseResult.diagnostics.length > 0) {`
	`2391`	`+ this.updateSquiggles(intelliSenseResult.uri, intelliSenseResult.diagnostics, intelliSenseResult.clearExistingDiagnostics);`
	`2392`	`+ }`
`2391`	`2393`	`}`
`2392`	`2394`
`2393`	`2395`	`private updateSquiggles(uriString: string, diagnostics: IntelliSenseDiagnostic[], startNewSet: boolean): void {`