fixes issue #662 (enables Pointer Lock Web API) #210875
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
reviewed
Jul 12, 2024
| @@ -166,7 +166,10 @@ export class CodeApplication extends Disposable { | |||
|
|
|||
| const isUrlFromWebview = (requestingUrl: string | undefined) => requestingUrl?.startsWith(`${Schemas.vscodeWebview}://`); | |||
|
|
|||
| const allowedPermissions = new Set(['pointerLock']); | |||
There was a problem hiding this comment.
Does this need to be enabled for the root document too? The only use case seems to be for webviews
There was a problem hiding this comment.
Yes the permission did not work until I added it to the root. That is to say I also needed the permission on the containing frame in order for the child to function in my extension's Webview.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes microsoft/vscode-extension-samples#662
#221593
By explicitly allowing the
pointerLockpermission in the root document of the VS Code window.Testing
aesthetic-computer.aesthetic-computer-codeextension in the Marketplace.Aesthetic Computerpane from the Activity Bar.fpsand press[Enter].[Escape]to end the Pointer Lock.