Bump node, update pacakges (#16718)

* Update node and ts

* Remove ock

* Add nock back

* Updates

* Updates

* Fixes

* Updates

Author: DonJayamanne

.devcontainer/dev-with-python/Dockerfile

@@ -6,7 +6,7 @@ FROM mcr.microsoft.com/vscode/devcontainers/python:3
 ENV NVM_DIR /usr/local/nvm
 RUN mkdir -p $NVM_DIR
 RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.5/install.sh | bash
-ENV NODE_VERSION 20.17.0
+ENV NODE_VERSION 22.15.1
 ENV NODE_PATH $NVM_DIR/v$NODE_VERSION/lib/node_modules
 ENV PATH $NVM_DIR/versions/node/v$NODE_VERSION/bin:$PATH
 

.devcontainer/dev/Dockerfile

@@ -1,6 +1,6 @@
 # See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.169.0/containers/python-3-miniconda/.devcontainer/base.Dockerfile
 
-FROM node:20.17.0-bullseye-slim
+FROM node:22.15.1-bullseye-slim
 
 RUN apt-get -y update
 RUN apt-get -y install apt-utils git gnupg2 curl locales ca-certificates sudo

.github/workflows/build-test.yml

@@ -26,7 +26,7 @@ on:
   workflow_dispatch:
 
 env:
-  NODE_VERSION: 20.17.0
+  NODE_VERSION: 22.15.1
   NPM_VERSION: 10.8.2
   PYTHON_VERSION: 3.8
   DENO_VERSION: '~1.37'

.nvmrc

@@ -1 +1 @@
-v20.17.0
+22.15.1

CONTRIBUTING.md

@@ -13,7 +13,7 @@
 
 ### Prerequisites
 
-1. [Node.js](https://nodejs.org/) 20.17.0
+1. [Node.js](https://nodejs.org/) 22.15.1
 2. [npm](https://www.npmjs.com/) 10.8.2
 3. [Python](https://www.python.org/) 3.6 or later
 4. Windows, macOS, or Linux

package-lock.json

@@ -2369,9 +2369,9 @@
         "zeromqold": "npm:zeromq@^6.0.0-beta.6"
     },
     "devDependencies": {
-        "@actions/core": "^1.9.1",
-        "@actions/github": "^4.0.0",
-        "@actions/glob": "^0.3.0",
+        "@actions/core": "^1.11.1",
+        "@actions/github": "^6.0.1",
+        "@actions/glob": "^0.5.0",
         "@babel/polyfill": "^7.4.4",
         "@istanbuljs/nyc-config-typescript": "^1.0.2",
         "@sinonjs/fake-timers": "^6.0.1",
@@ -2395,8 +2395,8 @@
         "@types/memoize-one": "^4.1.1",
         "@types/mocha": "^10.0.10",
         "@types/nock": "^10.0.3",
-        "@types/node": "^20.17.0",
-        "@types/node-fetch": "^2.5.7",
+        "@types/node": "^22.15.1",
+        "@types/node-fetch": "^2.6.12",
         "@types/pdfkit": "^0.11.0",
         "@types/promisify-node": "^0.4.0",
         "@types/react": "^16.4.14",
@@ -2419,7 +2419,7 @@
         "@types/uuid": "^3.4.3",
         "@types/uuid-to-hex": "^1.1.0",
         "@types/vscode-notebook-renderer": "^1.60.0",
-        "@types/webpack-env": "^1.18.1",
+        "@types/webpack-env": "^1.18.8",
         "@types/ws": "^6.0.1",
         "@typescript-eslint/eslint-plugin": "^6.9.0",
         "@typescript-eslint/eslint-plugin-tslint": "^6.9.0",
@@ -2506,9 +2506,9 @@
         "ts-mock-imports": "^1.3.0",
         "ts-mockito": "^2.6.1",
         "tsconfig-paths-webpack-plugin": "^3.2.0",
-        "tsx": "^3.13.0",
+        "tsx": "^4.19.4",
         "typemoq": "^2.1.0",
-        "typescript": "^5.7.2",
+        "typescript": "^5.8.3",
         "unicode-properties": "^1.3.1",
         "utf-8-validate": "^5.0.8",
         "util": "^0.12.4",

package.json

@@ -39,9 +39,10 @@ export interface INodeProcess {
     arch: string;
     env: IProcessEnvironment;
     versions?: {
+        node?: string;
         electron?: string;
+        chrome?: string;
     };
-    sandboxed?: boolean;
     type?: string;
     cwd: () => string;
 }
@@ -57,15 +58,13 @@ let nodeProcess: INodeProcess | undefined = undefined;
 if (typeof globals.vscode !== 'undefined' && typeof globals.vscode.process !== 'undefined') {
     // Native environment (sandboxed)
     nodeProcess = globals.vscode.process;
-} else if (typeof process !== 'undefined') {
+} else if (typeof process !== 'undefined' && typeof process?.versions?.node === 'string') {
     // Native environment (non-sandboxed)
     nodeProcess = process;
 }
 
 const isElectronProcess = typeof nodeProcess?.versions?.electron === 'string';
-const isElectronRenderer =
-    isElectronProcess && nodeProcess?.type && ['renderer', 'utility'].includes(nodeProcess?.type);
-export const isElectronSandboxed = isElectronRenderer && nodeProcess?.sandboxed;
+const isElectronRenderer = isElectronProcess && nodeProcess?.type === 'renderer';
 
 interface INavigator {
     userAgent: string;
@@ -74,25 +73,8 @@ interface INavigator {
 }
 declare const navigator: INavigator;
 
-// Web environment
-if (typeof navigator === 'object' && !isElectronRenderer) {
-    _userAgent = navigator.userAgent;
-    _isWindows = _userAgent.indexOf('Windows') >= 0;
-    _isMacintosh = _userAgent.indexOf('Macintosh') >= 0;
-    _isIOS =
-        (_userAgent.indexOf('Macintosh') >= 0 ||
-            _userAgent.indexOf('iPad') >= 0 ||
-            _userAgent.indexOf('iPhone') >= 0) &&
-        !!navigator.maxTouchPoints &&
-        navigator.maxTouchPoints > 0;
-    _isLinux = _userAgent.indexOf('Linux') >= 0;
-    _isWeb = true;
-    _locale = navigator.language;
-    _language = _locale;
-}
-
 // Native environment
-else if (typeof nodeProcess === 'object') {
+if (typeof nodeProcess === 'object') {
     _isWindows = nodeProcess.platform === 'win32';
     _isMacintosh = nodeProcess.platform === 'darwin';
     _isLinux = nodeProcess.platform === 'linux';
@@ -115,6 +97,23 @@ else if (typeof nodeProcess === 'object') {
     _isNative = true;
 }
 
+// Web environment
+else if (typeof navigator === 'object' && !isElectronRenderer) {
+    _userAgent = navigator.userAgent;
+    _isWindows = _userAgent.indexOf('Windows') >= 0;
+    _isMacintosh = _userAgent.indexOf('Macintosh') >= 0;
+    _isIOS =
+        (_userAgent.indexOf('Macintosh') >= 0 ||
+            _userAgent.indexOf('iPad') >= 0 ||
+            _userAgent.indexOf('iPhone') >= 0) &&
+        !!navigator.maxTouchPoints &&
+        navigator.maxTouchPoints > 0;
+    _isLinux = _userAgent.indexOf('Linux') >= 0;
+    _isWeb = true;
+    _locale = navigator.language;
+    _language = _locale;
+}
+
 // Unknown environment
 else {
     console.error('Unable to resolve platform.');

src/platform/vscode-path/platform.ts

@@ -12,7 +12,7 @@ export class MockMemento implements Memento {
     public get<T>(key: string, defaultValue?: T): T {
         const exists = this._value.hasOwnProperty(key);
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        return exists ? this._value[key] : (defaultValue! as any);
+        return exists ? (this._value[key] as any) : (defaultValue! as any);
     }
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     public update(key: string, value: any): Thenable<void> {

src/test/mocks/mementos.ts

@@ -793,12 +793,11 @@ export namespace vscMockExtHostedTypes {
 
         get(uri: vscUri.URI): TextEdit[] {
             if (!this._textEdits.has(uri.toString())) {
-                // @ts-ignore
-                return undefined;
+                return [];
             }
             // @ts-ignore
             const { edits } = this._textEdits.get(uri.toString());
-            return edits ? edits.slice() : undefined;
+            return edits ? edits.slice() : [];
         }
 
         entries(): [vscUri.URI, TextEdit[]][] {

src/test/mocks/vsc/extHostedTypes.ts

@@ -18,7 +18,8 @@ function convertVSCodeOutputToExecuteResultOrDisplayData(outputItem: OutputItem)
           _vsc_test_cellIndex?: number;
       })
     | undefined {
-    return outputItem.mime.toLowerCase().includes('json') ? outputItem.json() : outputItem.text();
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    return outputItem.mime.toLowerCase().includes('json') ? outputItem.json() : (outputItem.text() as any);
 }
 
 /**