Avoid exception by improving `makefile.additionalCompilerNames` handling to automatically escape characters like `+`

[gpaterson]

Hi,

I'm trying to setup makefile tools to be able to cross compile for Nios II within vscode and have run into the same issue when attempting to run Makefile: Configure, Makefile: Clean Configure. On attempting to Debug or Run I see: Cannot run because there is no launch configuration set and the list of launch targets is empty. Double check the makefile configuration and the build target. (The build target is set to all and the build is successful) I have defined a launch target in a launch.json file but there doesn't seem to be a way of selecting this or associating it with my Makefile project.

When I attempt to run Makefile: Configure I see the following output:

The project needs a configure to populate the launch targets correctly.
Saving opened files before build.
Generating configuration cache with command: 'make all --dry-run --keep-going --print-directory'
Writing the dry-run output: /home/user/.config/Code/User/workspaceStorage/6f0a7708412f42e0089d7c9c03759fd3/ms-vscode.makefile-tools/dryrun.log
Generating dry-run elapsed time: 0.175
Preprocessing: "/home/user/.config/Code/User/workspaceStorage/6f0a7708412f42e0089d7c9c03759fd3/ms-vscode.makefile-tools/dryrun.log"
Preprocess elapsed time: 0
Parsing for IntelliSense.
Updating the CppTools IntelliSense Configuration Provider.
Parsing dry-run output for CppTools Custom Configuration Provider.
Exception thrown during the configure process: Invalid regular expression: /^[\s"](.?)((([a-zA-Z0-9-.]*-)*ccache(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*clang++(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*clang-cl(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*clang-cpp(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*clang(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*gcc(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*gpp(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*cpp(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*icc(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*cc(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*icl(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*cl(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*g++(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*c++(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*nios2-elf-gcc(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*nios2-elf-ar(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*nios2-elf-g++(-[a-zA-Z0-9-.]))|(([a-zA-Z0-9-.]*-)*nios2-elf-nm(-[a-zA-Z0-9-.])))(\s|"\s)(.*)$/gm: Nothing to repeat

[gcampbell-msft]

Could you help us by providing some more information:

1. A repro project so that we can better investigate.
2. Which version of the extension this started in? Does it reproduce in older versions?
3. If it only reproduces in the most recent official release version, it'd be great if you could install the pre-release and deduce which pre-release version this starts reproducing in.

Thanks! @Yingzi1234 FYI.

[Yingzi1234]

@gpaterson Could you give us a repro program?

[gpaterson]

Hi all,
I have been looking further into this and did manage to workaround using Run & Debug rather than Makefile tools. I should probably also have mentioned that this is only an issue when cross compiling for Intel's nios ii architecture which needs definition of a specific toolchain. I imagine the problem can be reproduced by adding links to specific compiler, linker and debugger programs as I have done but will add a repro project so that it's clearer.

[Amy-Li03]

Hi @gpaterson , thanks for your investigation and reply!
Once we receive your repro project, we'll try to reproduce it.

[TurnOffNOD]

I encounter this "Exception thrown during the configure process: Invalid regular expression" error too. I use this vscode-makefile-tools latest "Release" branch, directly install from vscode "Extensions" tab, the version is 0.12.17 when I post.

I am not cross-compiling, it is a small learning project developing under mingw64 and compiling to x86_64.

Edit: pre-release version when I post, version number 0.13.4 also has this exception.

[Amy-Li03]

Hi @TurnOffNOD, thanks for your info!
That would be great if you can share your small learning project for us to repro this issue, thanks in advance.

[TurnOffNOD]

Hi @TurnOffNOD, thanks for your info! That would be great if you can share your small learning project for us to repro this issue, thanks in advance.

Here it is: https://github.com/TurnOffNOD/random2image-learning

[Amy-Li03]

@TurnOffNOD, thanks for your demo project!

After clone project and run command: Makefile: Configure, we don't see "Exception thrown during the configure process: Invalid regular expression", could you please tell us if there are extra steps need to be taken.

[TurnOffNOD]

@TurnOffNOD, thanks for your demo project!

After clone project and run command: Makefile: Configure, we don't see "Exception thrown during the configure process: Invalid regular expression", could you please tell us if there are extra steps need to be taken.

Oh, before that, I updated the vscode C/C++(ms-vscode.cpptools) plugin's IntelliSense Configuration Provider to Makefile Tools(ms-vscode.makefile-tools). This step is half automatically, all that I do is click "Yes" buttons when a small windows shows up, I am not sure is this "extra steps".

Then I opened the folder, Makefile:configure and the error arises.

I see the bottom right corner shows "C++", my code is in C (C23 standard), is that a bug or something?

And I installed many other vscode plugins, is that related?

[Amy-Li03]

@TurnOffNOD Double checked on our side that the C_Cpp.default.configurationProvider is ms-vscode.makefile-tools, and the Language Mode in the bottom right corner is Auto Detect, is it same as yours?
In addition, could you please try disable other vscode plugins to see whether your issue still repro? if you have other findings, please let us know.

[TurnOffNOD]

@TurnOffNOD Double checked on our side that the C_Cpp.default.configurationProvider is ms-vscode.makefile-tools, and the Language Mode in the bottom right corner is Auto Detect, is it same as yours? In addition, could you please try disable other vscode plugins to see whether your issue still repro? if you have other findings, please let us know.

I will test tomorrow.

[TurnOffNOD]

@TurnOffNOD Double checked on our side that the C_Cpp.default.configurationProvider is ms-vscode.makefile-tools, and the Language Mode in the bottom right corner is Auto Detect, is it same as yours? In addition, could you please try disable other vscode plugins to see whether your issue still repro? if you have other findings, please let us know.

Hi, sorry for my late reply. I checked carefully, and find out the setting item makefile.additionalCompilerNames matters.

Related part of my old settings.json is as follows:

    "makefile.additionalCompilerNames": [
        "clang++",
        "g++",
        "clang",
        "gcc"
    ],

When I delete these lines, this extension makefile-tools works all good without "Invalid regular expression" when "Makefile: Configure". After I add these lines, this extension will fail with "Invalid regular expression" when "Makefile: Configure".

Now the 2 settings.json(renamed of course) have push to my small learning project repo .