Feature Request - Ctrl+N should create a sql query connected appropriately

[LarnuUK]

More basic functionality in both ADS and SSMS. When a database is selected in the object explorer, pressing Ctrl+N opens a new query window with a connection to that server and database; mssql does not do this. Ctrl+N doesn't even create a new query window in the correct language; it creates a new blank window, nothing more. If you change the language to sql, it doesn't automatically connect to the correct server or database either (or was not before).

If you are in another SQL query, and press Ctrl+N this should open up another SQL Query, connected to the same database. There should be none of this faffing around to change language, connect to the correct server, change the database context, etc. It literally changes something that was 2 keys to 2 keys and 4+ mouse clicks. That's significantly poor UX.

This, like other basic functionality, is a must for those being forced to migrate from ADS due to its deprecation.

[match-gabeflores]

Agree, but this is a Dupe
#18556

[LarnuUK]

Agree, but this is a Dupe #18556

Some of it, but not all of it. It doesn't reference the object explorer at all.

[quinndev4]

I agree that this is very poor UX. It's making the migration from ADS to VSCode mssql quite bothersome. I just posted on stack overflow about this as well. A commenter linked me to this issue. glad others feel the same

[kburtram]

Thanks for raising this issue. Unfortunately, we can't override the default VS Code behavior for Ctrl+N, as it's globally mapped to "New File". However, we can definitely add a new dedicated command like "Open New SQL File with Current Connection". Once added, you'll be able to assign it to whichever shortcut you prefer in your keybindings settings.

Does that sound like a workable solution?

[LarnuUK]

You should make Ctrl+N an override, @kburtram ; that is the command in ADS and SSMS and it needs to be the command in VSCode. It can be context driver but it needs to behave correctly and as expected. If VSCode can't do this it's a further example it's not a replacement, and the deprecation should be reversed. This is fundamental behaviour.

Does that sound like a workable solution?

No.

[kburtram]

You should make Ctrl+N an override, @kburtram ; that is the command in ADS and SSMS and it needs to be the command in VSCode. It can be context driver but it needs to behave correctly and as expected. If VSCode can't do this it's a further example it's not a replacement, and the deprecation should be reversed. This is fundamental behaviour.

Does that sound like a workable solution?

No.

Thanks for clarifying your concerns here. VS Code allows users to override default shortcuts like Ctrl+N manually through the keybindings settings (as shown below).

However, since overriding default shortcuts at the extension level is against recommended best practices for extensions (to avoid disrupting standard VS Code behavior for all users), we won't set this as a default in the extension itself.

But you're definitely welcome to configure this manually if you'd prefer the ADS/SSMS behavior.

[LarnuUK]

I disagree it's "best practice" to have non-standard behaviour for the tool, if I am honest. If that is the way, the explicit documentation needs to be provided to aid users correct the non-standard behaviour, and make it context aware (when you are connected to SQL Server).

[stephenmcd1]

I agree that having Ctrl + N work 'out of the box' would be ideal for folks coming from SSMS or ADS. However, I also don't think it's the end of the world to require users to set up their own keybinding. In fact, after just a few hours of trying out this extension, I sent a message to my team with my tweaked keybindings.json file so they could quickly setup their own environment. It was annoying but only took a bit of time.

I still would really like a command that opens a new query tab with the same connection as the current tab (or change the behavior of the existing mssql.newQuery command to do that). But I think this is covered by #18556 (and perhaps that issue could be updated to mention Object Explorer as well?)

One thing that might be really helpful would be an entry in the Walkthrough that you get when first installing the extension. That entry could be all about helping folks who are coming from ADS or SSMS (which could start to be a lot of people as ADS falls out of support). The entry could talk about changes to keyboard shortcuts and other things that folks have mentioned in various Issues. For some problems that folks have, the solution may not be a code change but instead a documentation change (and the Walkthrough seems like a great way to get some documentation in peoples' faces).

[LarnuUK]

I've been taking notes on what I've had to change so far, @stephenmcd1 , so I can write up something close to the full deprecation. Though I could now, there's too much missing, and a lot of work to be done over the next ~11 months so that things improve and are more "ADS/SSMS like" for those being forced to MSSQL, that such content written now could easily be out of date in a few months.