Fix file read API to use modern Node.js fs promises and expand error handling

Agent-Logs-Url: https://github.com/microsoft/vscode-sublime-keybindings/sessions/96004e9f-5b64-488f-9019-381b82965b88

Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>

Author: Copilot

src/extension.ts

@@ -97,7 +97,14 @@ function validate(settingsFilePath: string): boolean {
 }
 
 async function getSettings(sublimeSettingsPath: string): Promise<CategorizedSettings> {
-    const settings: CategorizedSettings | undefined = await mapper.getMappedSettings(await readFileAsync(sublimeSettingsPath, 'utf-8'));
+    let fileContents: string;
+    try {
+        fileContents = await readFileAsync(sublimeSettingsPath, 'utf-8');
+    } catch (e: any) {
+        vscode.window.showErrorMessage(vscode.l10n.t('Could not read Sublime settings file: {0}', e.message));
+        throw e;
+    }
+    const settings: CategorizedSettings | undefined = await mapper.getMappedSettings(fileContents);
     settings.mappedSettings.sort((a, b) => {
         if (a.vscode.overwritesValue && b.vscode.overwritesValue) {
             return a.sublime.name.localeCompare(b.sublime.name);

src/fsWrapper.ts

@@ -2,22 +2,13 @@ import * as fs from 'fs';
 
 export async function pathExists(stringPath: string): Promise<boolean> {
     try {
-        await fsAccess(stringPath, fs.constants.F_OK);
+        await fs.promises.access(stringPath, fs.constants.F_OK);
         return true;
     } catch (e) {
         return false;
     }
 }
 
-function fsAccess(stringPath: string, checks: number): Promise<any> {
-    return promisifier(fs.access, stringPath, checks);
-}
-
-// adapted from vs/base/common/async
-export function promisifier<T>(fn: Function, ...args: any[]): Promise<T> {
-    return new Promise((c, e) => fn(...args, (err: any, result: any) => err ? e(err) : c(result)));
-}
-
-export async function readFileAsync(filePath: string, encoding?: string): Promise<string> {
-    return await promisifier<string>(fs.readFile, filePath, encoding);
+export async function readFileAsync(filePath: string, encoding: BufferEncoding = 'utf-8'): Promise<string> {
+    return fs.promises.readFile(filePath, encoding);
 }

src/mapper.ts

@@ -34,8 +34,17 @@ export class Mapper {
     private async getSettings(): Promise<IMapperSettings> {
         if (!this.settings) {
             // make sure set node: false in /build/node_extension.webpack.config.json so that __dirname is correct
-            const [mappingsFile, defaultsFile] = await Promise.all([readFileAsync(resolve(__dirname, '..', 'settings/mappings.json'), 'utf-8'), 
-                                                                    readFileAsync(resolve(__dirname, '..', 'settings/defaults.json'), 'utf-8')]);
+            let mappingsFile: string;
+            let defaultsFile: string;
+            try {
+                [mappingsFile, defaultsFile] = await Promise.all([
+                    readFileAsync(resolve(__dirname, '..', 'settings/mappings.json'), 'utf-8'),
+                    readFileAsync(resolve(__dirname, '..', 'settings/defaults.json'), 'utf-8'),
+                ]);
+            } catch (e: any) {
+                vscode.window.showErrorMessage(vscode.l10n.t('Could not read settings files: {0}', e.message));
+                throw e;
+            }
             this.settings = {
                 mappings: jsoncParse(mappingsFile),
                 defaults: (jsoncParse(defaultsFile) as [[string, any]]).map((setting) => new VscodeSetting(setting[0], setting[1])),