Skip to content

Commit 1410d77

Browse files
reverse cancellation and sequencer (#237029)
When we cancel, then the promise should be cancelled. If we don't do this, we hang on the first interaction request until we timeout. Fixes the 2nd point in #236825 (comment)
1 parent 0a66dc3 commit 1410d77

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

extensions/microsoft-authentication/src/node/cachedPublicClientApplication.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -133,11 +133,11 @@ export class CachedPublicClientApplication implements ICachedPublicClientApplica
133133
cancellable: true,
134134
title: l10n.t('Signing in to Microsoft...')
135135
},
136-
(_process, token) => raceCancellationAndTimeoutError(
137-
this._sequencer.queue(() => this._pca.acquireTokenInteractive(request)),
136+
(_process, token) => this._sequencer.queue(() => raceCancellationAndTimeoutError(
137+
this._pca.acquireTokenInteractive(request),
138138
token,
139139
1000 * 60 * 5
140-
)
140+
))
141141
);
142142
// this._setupRefresh(result);
143143
if (this._isBrokerAvailable) {

0 commit comments

Comments
 (0)