-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt selection support in notebook diff / interactive editor to enable in-editor history #142507
Comments
Thanks, I can verify in endgame. |
I think this still does not work in notebook diff editors. |
Screen.Recording.2022-05-04.at.10.49.57.AM.mov@bpasero can you check above video to verify if that's what you are seeing too?:
|
@rebornix this is not about navigating from a different editor back to the right cell but rather about navigating between cells from within the same editor 👍 . The idea is that an editor can emit selection change events whenever a meaningful selection change happens that should add to the history stack. For example, in the text editor case this happens when you move the mouse around inside the editor. |
7858e23#diff-330f92e5612e8f9dcc91e85d694b6e10fdaa5f14c384157edfd27dfbbf0f8684 added support for selection in notebook editor to participate in history navigation by recording locations for each cell change. This is not yet adopted for these two:
NotebookTextDiffEditor
InteractiveEditor
Fyi for text diff editors we implemented this in a simple way by just delegating to the right hand (modified) side. This is not 100% correct because you could compare 2 different files via explorer where both sides are editable, but I have not heard complaints so far.
The text was updated successfully, but these errors were encountered: