Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt selection support in notebook diff / interactive editor to enable in-editor history #142507

Open
bpasero opened this issue Feb 8, 2022 · 6 comments
Assignees
Labels
debt Code quality issues notebook verification-needed Verification of issue is requested workbench-history History item issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Feb 8, 2022

7858e23#diff-330f92e5612e8f9dcc91e85d694b6e10fdaa5f14c384157edfd27dfbbf0f8684 added support for selection in notebook editor to participate in history navigation by recording locations for each cell change. This is not yet adopted for these two:

  • NotebookTextDiffEditor
  • InteractiveEditor

Fyi for text diff editors we implemented this in a simple way by just delegating to the right hand (modified) side. This is not 100% correct because you could compare 2 different files via explorer where both sides are editable, but I have not heard complaints so far.

@bpasero bpasero added workbench-history History item issues notebook labels Feb 8, 2022
@bpasero bpasero changed the title Adopt selection support in notebook diff / interactive editor Adopt selection support in notebook diff / interactive editor to enable history Feb 8, 2022
@bpasero bpasero changed the title Adopt selection support in notebook diff / interactive editor to enable history Adopt selection support in notebook diff / interactive editor to enable in-editor history Feb 8, 2022
@rebornix rebornix added this to the February 2022 milestone Feb 8, 2022
@rebornix rebornix modified the milestones: February 2022, March 2022 Feb 23, 2022
@rebornix rebornix modified the milestones: March 2022, April 2022 Mar 23, 2022
@rebornix rebornix added the debt Code quality issues label Mar 23, 2022
@bpasero bpasero added the verification-needed Verification of issue is requested label Mar 29, 2022
@bpasero
Copy link
Member Author

bpasero commented Mar 29, 2022

Thanks, I can verify in endgame.

@bpasero bpasero reopened this Apr 26, 2022
@bpasero bpasero added the verification-found Issue verification failed label Apr 26, 2022
@bpasero
Copy link
Member Author

bpasero commented Apr 26, 2022

I think this still does not work in notebook diff editors.

@rebornix rebornix modified the milestones: April 2022, May 2022 Apr 28, 2022
@rebornix
Copy link
Member

rebornix commented May 4, 2022

Screen.Recording.2022-05-04.at.10.49.57.AM.mov

@bpasero can you check above video to verify if that's what you are seeing too?:

  • Open a diff editor
  • Click into different cells
  • Open another editor
  • Go back should navigate back to diff editor and open previously focused cell

@rebornix rebornix added info-needed Issue requires more information from poster and removed verification-found Issue verification failed labels May 4, 2022
@bpasero bpasero reopened this May 27, 2022
@bpasero bpasero removed the info-needed Issue requires more information from poster label May 27, 2022
@bpasero
Copy link
Member Author

bpasero commented May 27, 2022

@rebornix this is not about navigating from a different editor back to the right cell but rather about navigating between cells from within the same editor 👍 . The idea is that an editor can emit selection change events whenever a meaningful selection change happens that should add to the history stack. For example, in the text editor case this happens when you move the mouse around inside the editor.

@rebornix rebornix modified the milestones: May 2022, June 2022 Jun 1, 2022
@rebornix rebornix removed this from the June 2022 milestone Jun 29, 2022
@rebornix rebornix added this to the July 2022 milestone Jun 29, 2022
@rebornix rebornix modified the milestones: July 2022, August 2022 Jul 27, 2022
@rebornix rebornix modified the milestones: August 2022, September 2022 Aug 19, 2022
@rebornix rebornix modified the milestones: September 2022, October 2022 Sep 29, 2022
@rebornix rebornix modified the milestones: October 2022, November 2022 Oct 21, 2022
@rebornix rebornix modified the milestones: November 2022, Backlog Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues notebook verification-needed Verification of issue is requested workbench-history History item issues
Projects
None yet
Development

No branches or pull requests

4 participants
@rebornix @bpasero @greazer and others