Support setting a badge-only color in file decorations

[eamodio]

Today we can provide a ThemeColor to a file decoration, but it automatically applies to the text of the file as well as the badge.

There are cases where I really want the badge to have a color, but not affect the text itself.

Here is an example from the SCM view today that has color on the badges but not the text:

While in GitLens I want the M to be colored like the SCM view above, but not apply the same color to the text -- which I can't do today:

My guess is that we don't want to add the ability to have a badgeColor, since then you could end up with different text colors and badge colors (though in some cases it would be nice, could lead to not great experiences), but rather add a colorAppliesTo property (or something similarly named) with values of all (default), text, badge.

/cc @alexr00 pinging you as I believe you are looking into badge changes for codicons in May

[alexr00]

We currently have the setting explorer.decorations.colors which controls whether the color is applied to just the badge or the whole text in the file explorer. We could have a setting to do the same for all extension trees.

@jrieken do you think this should be API or a setting?

@joaomoreno I think SCM is the outlier on behavior here. I couldn't find a setting for SCM that's similar to explorer.decorations.colors. Should we make the behavior consistent across all trees?

[eamodio]

While a setting is a nice override for users, I still think an API is better for granular control. Some decorations can warrant full color while others it becomes too distracting.

[joaomoreno]

@joaomoreno I think SCM is the outlier on behavior here. I couldn't find a setting for SCM that's similar to explorer.decorations.colors. Should we make the behavior consistent across all trees?

cc @lszomoru

[eamodio]

Please don't make the SCM consistent with the badge color and text color having to match -- that would make all modified files have a color and it would be like a rainbow. But at the same time having no color on the badge makes it easier to miss. IMO, the current SCM view is a better experience, and I would want THAT consistent with other views.

[alexr00]

@lramos15 and @lszomoru I am happy to make extension tree views match whichever we decide the default should be.

[VSCodeTriageBot]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[lramos15]

the current SCM view is a better experience, and I would want THAT consistent with other views.

I think this depends. I'm not sure there is a sane default here.

In the explorer, I quite like that the text is colored as well since it helps with distinguishing changed items from the rest. However, I understand in the SCM this would be super annoying as then everything would be highlighted since all files in the SCM view are changed files.

To me, the text colorization works well when you have sparse decorations sprinkled throughout a larger tree versus having every item or a majority of items in the tree decorated.

[alexr00]

@lramos15 this makes perfect sense. In that case, it should be up to the extension that provides the decoration whether everything is colored or just the badge.

[VSCodeTriageBot]

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[VSCodeTriageBot]

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!