Support Data Breakpoints across sessions

[KutluOzel-b]

We are implementing a debugger extension, which is working as a remote debugger.
While implementing data breakpoints feature, we found out there is no source binding approach and programatically control over data breakpoints which causes multiple problems.

To resolve those issues we need a support for ;

• Data breakpoints can be created / removed programatically.
• Source bound (although we can achieve this with dataId generated by dataBreakpointInfo method on DAP, it would be much better to manage if they are alike line breakpoints considering complexity of the methods while multiple sesions active.

[KutluOzel-b]

Since the feature is not yet planned nor considered yet, we offer to contribute to it...

There will be an implementation of adding DataBreakpoints class to vscode api declaration file like :

export class DataBreakpoint extends Breakpoint {
		readonly dataId: string;
		readonly accessType: DebugProtocol.DataBreakpointAccessType;
		/**
		 * Create a new data breakpoint.
		 */
		constructor(dataId: string, accessType: DebugProtocol.DataBreakpointAccessType, enabled?: boolean, condition?: string, hitCondition?: string, logMessage?: string);
	}

So we can use it when calling addBreakpoint method in vscode debug api.

And with the help of databreakpointrenderer and addDataBreakpoint method, which is already on debug model, we can create DataBreakpoints programmatically when we are developing our extension.

Didn't tried the rest but I think it will be stored and can be obtained with the storage service and the rest is looking available and nothing much needs to be done to make it line sourceBreakpoints function breakpoints which can be created programmatically.

Any feedback on this ?

[VSCodeTriageBot]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[VSCodeTriageBot]

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[haydar-metin]

Hello!
We would also need to create data breakpoints through the extension API, and while searching for a solution, we've identified a gap in the VSCode implementation for data breakpoints. The method extHostDebugService.ts#addBreakpoints currently lacks the ability to forward data breakpoints (i.e., missing DTOs), while MainThreadDebugService.ts#$registerBreakpoints already supports it.
We propose updating extHostDebugService.ts#addBreakpoints to process data breakpoints similarly to other types of breakpoints. The solution would be, as already mentioned, introducing a new DataBreakpoint class and updating the respective API.

@KutluOzel-b did you have any progress so far to create data breakpoints? Thanks!