Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to find the active comment thread #204484

Open
alexr00 opened this issue Feb 6, 2024 · 1 comment · Fixed by #204486
Open

API to find the active comment thread #204484

alexr00 opened this issue Feb 6, 2024 · 1 comment · Fixed by #204486
Assignees
Labels
api api-proposal comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Feb 6, 2024

This would enable extensions to provide keybindings for the active comment thread.

Example: microsoft/vscode-pull-request-github#5261

@alexr00 alexr00 added feature-request Request for new features or functionality api api-proposal labels Feb 6, 2024
@alexr00 alexr00 added this to the February 2024 milestone Feb 6, 2024
@alexr00 alexr00 self-assigned this Feb 6, 2024
@alexr00 alexr00 added the comments Comments Provider/Widget/Panel issues label Feb 6, 2024
alexr00 added a commit that referenced this issue Feb 6, 2024
@alexr00
Copy link
Member Author

alexr00 commented Feb 6, 2024

declare module 'vscode' {
// @alexr00 https://github.com/microsoft/vscode/issues/204484
export interface CommentController {
/**
* The currently active comment or `undefined`. The active comment is the one
* that currently has focus or, when none has focus, undefined.
*/
// readonly activeComment: Comment | undefined;
/**
* The currently active comment thread or `undefined`. The active comment thread is the one
* that currently has focus or, when none has focus, undefined.
*/
readonly activeThread: CommentThread | undefined;
}
}

alexr00 added a commit that referenced this issue Feb 7, 2024
* API to find the active comment thread
Fixes #204484

* Add issue ref

* Add activeComment proposal to api tests

* Add settimeout to blur event
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Feb 7, 2024
@alexr00 alexr00 reopened this Feb 7, 2024
@VSCodeTriageBot VSCodeTriageBot removed the unreleased Patch has not yet been released in VS Code Insiders label Feb 7, 2024
alexr00 added a commit that referenced this issue Feb 7, 2024
alexr00 added a commit that referenced this issue Feb 7, 2024
@alexr00 alexr00 modified the milestones: February 2024, On Deck Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api api-proposal comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants