Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird looking Output selector menu #208026

Open
2 tasks
hbons opened this issue Mar 18, 2024 · 1 comment
Open
2 tasks

Weird looking Output selector menu #208026

hbons opened this issue Mar 18, 2024 · 1 comment
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues electron Issues and items related to Electron polish Cleanup and polish issue system-context-menu Issue related to context menu drawn by the OS upstream Issue identified as 'upstream' component related (exists outside of VS Code) ux User experience issues

Comments

@hbons
Copy link
Member

hbons commented Mar 18, 2024

  • 1. The font size of the the menu log selector in the Output view is too small. This makes the text look uncentered vertically.
  • 2. The separator is just a bunch of dashes "---" instead of a native separator. This is not good for accessibility.

It's possible that a smaller font size was chosen to be able to see more items in this relatively long menu. But that doesn't work in this case on macOS as the menu item height is still the same, so there aren't more items displayed than before.

If a more compact menu is desired, it's better to set the NSControlSize on macOS, instead of changing the font size. This will actually allow more menu items to be shown at the same time.

Here's a screenshot showing the text misalignment compared to a regular menu (right).

image

https://developer.apple.com/documentation/appkit/nscontrolsize

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.88.0-insider
  • OS Version: macOS

Steps to Reproduce:

  1. On macOS, open the Panel and click the Output tab.
  2. Notice misaligned text and non-native separator.
@hbons hbons added ux User experience issues accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues polish Cleanup and polish issue papercut 🩸 A particularly annoying issue impacting someone on the team and removed papercut 🩸 A particularly annoying issue impacting someone on the team labels Mar 18, 2024
@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron labels Mar 19, 2024
@bpasero
Copy link
Member

bpasero commented Mar 19, 2024

This would require changes in https://github.com/electron/electron, so marking as upstream.

@bpasero bpasero added the system-context-menu Issue related to context menu drawn by the OS label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues electron Issues and items related to Electron polish Cleanup and polish issue system-context-menu Issue related to context menu drawn by the OS upstream Issue identified as 'upstream' component related (exists outside of VS Code) ux User experience issues
Projects
None yet
Development

No branches or pull requests

3 participants