Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: "Open Folder" shows a "Select Folder" dropdown that seems a no-op #213768

Open
bpasero opened this issue May 29, 2024 · 2 comments
Open

Linux: "Open Folder" shows a "Select Folder" dropdown that seems a no-op #213768

bpasero opened this issue May 29, 2024 · 2 comments
Assignees
Labels
electron Issues and items related to Electron linux Issues with VS Code on Linux native-file-dialog Issues with native file dialog polish Cleanup and polish issue upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@bpasero
Copy link
Member

bpasero commented May 29, 2024

Testing #213763

See bottom right corner:

image

That does not exist in stable, not sure what its for.

@deepak1556
Copy link
Collaborator

Unlike file open dialogs, folder open dialog has only one filter that is already set internally so the user visible filter (the dropdown you are seeing) needs a name and chromium picks the default tile of the dialog https://source.chromium.org/chromium/chromium/src/+/main:ui/gtk/select_file_dialog_linux_gtk.cc;l=468-470. We can try removing that as polish.

@deepak1556 deepak1556 added upstream Issue identified as 'upstream' component related (exists outside of VS Code) linux Issues with VS Code on Linux polish Cleanup and polish issue electron Issues and items related to Electron native-file-dialog Issues with native file dialog labels May 29, 2024
@bpasero
Copy link
Member Author

bpasero commented May 29, 2024

I am fine closing this as wontfix is this is expected, I was just noticing that we did not have this before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron Issues and items related to Electron linux Issues with VS Code on Linux native-file-dialog Issues with native file dialog polish Cleanup and polish issue upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants