Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs still shown with "zenMode.showTabs": "none" #216822

Open
brussee opened this issue Jun 21, 2024 · 5 comments
Open

Breadcrumbs still shown with "zenMode.showTabs": "none" #216822

brussee opened this issue Jun 21, 2024 · 5 comments
Assignees
Labels
breadcrumbs bug Issue identified by VS Code Team member as probable bug feature-request Request for new features or functionality workbench-zen Full screen 'Zen' view issues
Milestone

Comments

@brussee
Copy link

brussee commented Jun 21, 2024

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.90.2
  • OS Version: Windows 11 Pro

Steps to Reproduce:

  1. Open any file in the editor
  2. Toggle Zen-mode on
@brussee
Copy link
Author

brussee commented Jun 21, 2024

Related: #195222

@jrieken
Copy link
Member

jrieken commented Jun 21, 2024

Sorry @isidorn but I don't know who own zen mode

@isidorn
Copy link
Contributor

isidorn commented Jun 21, 2024

I see zen-mode issues assigned to SteVen so will go ahead and assign to him. SteVen feel free to assign back to me.

@isidorn isidorn assigned sbatten and unassigned isidorn Jun 21, 2024
@isidorn isidorn added workbench-zen Full screen 'Zen' view issues and removed new release labels Jun 21, 2024
@benibenj benibenj added the bug Issue identified by VS Code Team member as probable bug label Aug 15, 2024
@benibenj benibenj added this to the September 2024 milestone Aug 15, 2024
@benibenj
Copy link
Contributor

benibenj commented Sep 5, 2024

zenMode.showTabs does not influence if breadcrumbs are shown, similar to workbench.editor.showTabs.
You can hide breadcrumbs with the breadcrumbs.enabled setting. Is a zen mode zenMode.breadcrumbsEnabled setting really needed here?

@benibenj benibenj removed this from the September 2024 milestone Sep 5, 2024
@brussee
Copy link
Author

brussee commented Sep 10, 2024

zenMode.showTabs does not influence if breadcrumbs are shown, similar to workbench.editor.showTabs. You can hide breadcrumbs with the breadcrumbs.enabled setting. Is a zen mode zenMode.breadcrumbsEnabled setting really needed here?

tl;dr: Yes.

Zen Mode currently has settings to: Hide Activity Bar, Hide Line Numbers, Hide Status Bar, (all enabled by default) among other settings.
The only thing missing is: Hide Breadcrumbs (enabled by default).

It's the only element remaining remaining before reaching true code zen: having only code editor on the screen and nothing else: no distractions like navigation breadcrumbs.

Thanks in advance for your effort!

edit:
Also: @benibenj in your comment: #195222 (comment) you wrote (emphasis added by me):

Allow to hide editor title section entirely (tabs, breadcrumbs) #33607

Changing showTabs from boolean to enum:

  • multiple: Multiple tabs with breadcrumbs below (if enabled)
  • single: One tab filling the entire width of the tab bar (this is the breadcrumb)
  • none: No tabs, no breadcrumbs

of which I use the "none" setting (BTW which I'd prefer to be the default :)

@benibenj benibenj added feature-request Request for new features or functionality breadcrumbs labels Sep 11, 2024
@benibenj benibenj added this to the Backlog milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breadcrumbs bug Issue identified by VS Code Team member as probable bug feature-request Request for new features or functionality workbench-zen Full screen 'Zen' view issues
Projects
None yet
Development

No branches or pull requests

6 participants