-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accessibility] Reading is no longer possible when hovering the mouse over items in the tab and explorer areas of the editor. #224704
Comments
I am not familiar with using the mouse cursor functionality. Could you pls provide exact steps and what happened before vs what's happening now (or not)? cc @rperez030 Thank you |
NVDA has a feature to read the object under the cursor. That is also part of magnification tools such as zoomtext. I understand they rely on the UIA_BoundingRectangle property to determine the object under the mouse, which I've heard is not very reliable in browsers. I'm personally not very familiar with it since it is not something i would use myself. |
I use the Japanese version of NVDA, so I don't know exactly how to enable that feature in the English version, but it is probably almost the same. To enable it, open the menu by pressing "NVDA Ki~ + N", select "Settings", and check "Mouse" under the category "Mouse" -> "Report text at mouse cursor position". Then, in various applications and browsers, when you move the mouse over the text, it will be read out loud. Because I have low vision, I work with the mouse cursor there and have the text read to me, while somehow perceiving the position of the text. In one previous version of VS Code (1.92 or earlier), I was able to read out the text without any problem. Is there some change in the structure of the DOM or is it a problem with the version of the Chrome Driver that is installed? I have tried various DOM change operations on my end using VS Code's developer tools, but so far it seems to have no effect. If that didn't help, you could listen for f-focus events on the JavaScript side, write the target text to the element with the " |
There is one sure cause for not reading them. If you want NVDA to read text under the mouse cursor, the object must be directly touching the mouse cursor. For example, as an example of how to make it unreadable, if you place a transparent DOM over the object for some purpose (using position:absolute, etc.) or create an object using CSS pseudo-classes (before, after, etc.), NVDA will not read NVDA will not read it. Also, I just downgraded the VS Code version to 1.91. I am reading the text under the mouse cursor with no problem. |
@deepak1556 know of any change that could've caused this? |
@ryusei-48 given this seems like a possible regression, it would help to know which change caused it. We maintain a node.js based CLI tool Steps:
Thanks! |
The range of problematic commits is now as follows git bisect start && git bisect bad 2fe05272052cf1f0ab2133f7f4874e9a748e8e74 && git bisect good b23e791eb5afbd95f05aa24da7693ce89344a079 Since the problem was with a release build, we ran the command as follows npx --yes --releasedOnly @vscode/vscode-bisect@latest The GitHub page summarizing the scope of the problematic commits is below. Thanks! |
We first reported that the text in the Explorer area and editor tabs was no longer being read out loud, but after much verification, we found that the text under the mouse cursor was no longer being read out loud over a fairly wide area. For example, the popup that appears in the lower right corner of the screen when there is some notification, the description popup that appears when the mouse cursor is over a TypeScript keyword or type, and all items on the settings page. It seems to me that something is wrong with the entire VS Code screen. |
I'm having the same issue. I am using the https://github.com/hwf1324/objectViewer NVDA add-on I developed to view the layout of the NVDAObject. Here is an example: The Report Issues window for the latest preview version Report issue window of an earlier preview version The difference between them can be observed with a new NVDAObject. |
On a side note, could this be related to Electron? Because one of the apps I use had a similar problem after one of the recent updates. It uses Electron as well. Of course I haven't investigated or tested it, just making a hypothesis. |
Thanks @ryusei-48 for the bisect results, the commit does reference an Electron update we had in 1.92 it could be very well be a regression in Chromium. I don't have the setup to confirm this issue yet, If anyone is interested in the meantime to investigate further please try the following next steps to bisect chromium builds,
|
Thank you for your research. As a result, it seems that there is a problem with cromium as you mentioned. The problem is happening in the following commit ranges CHANGELOG URL: |
Thanks for the quick turnaround, but looking at the commit history in that range only one commit is relevant to a11y but that is not bundled as part of our application. It could be that the bisect range is incorrect, can you try the chromium bisect again to confirm. |
OK, I tried again.
|
Related: electron/electron#42945 |
I created an NVDA add-on to temporarily fix this. |
Type: Bug
I use a screen reader. I often use the mouse cursor to read the text below it. However, when I upgraded to version 1.92, I encountered the title problem.
NVDA's mouse cursor reading function is used.
I hope it will be corrected.
バージョン: 1.92.0 (user setup)
コミット: b1c0a14
日付: 2024-07-31T23:26:45.634Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.22631
VS Code version: Code 1.92.0 (b1c0a14, 2024-07-31T23:26:45.634Z)
OS version: Windows_NT x64 10.0.22631
Modes:
System Info
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
Extensions (54)
(2 theme extensions excluded)
A/B Experiments
The text was updated successfully, but these errors were encountered: