You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Given we're serializing a lot of cells, we can easily serialize the cells one by one and then construct the bytes from that, instead of building a string.
This will address the issue, however we need a way to read the JSON as well,
However given that no one seems to be running into this issue (unable to save/load large notebooks), I'm changing this from bug to paper cut for now
DonJayamanne
added
papercut 🩸
A particularly annoying issue impacting someone on the team
and removed
bug
Issue identified by VS Code Team member as probable bug
labels
Oct 1, 2024
Given we're serializing a lot of cells, we can easily serialize the cells one by one and then construct the bytes from that, instead of building a string.
I.e. notebook = {cells: [.....], metadata: {...}}
pseudo code:
json = [TextEncoder.encode(
{
), ...notebook.cells.map(cell => TextEncoder.encode(JSON.stringify(cell)))];Given that we know the indent level, its easy to construct the JSON string in pieces of bytes.
The text was updated successfully, but these errors were encountered: