You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
bpasero opened this issue
Sep 10, 2024
· 0 comments
Assignees
Labels
confirmedIssue has been confirmed by VS Code Team memberdebtCode quality issueselectronIssues and items related to ElectronESMIssues caused by our AMD => ESM workupstreamIssue identified as 'upstream' component related (exists outside of VS Code)
// for (let i = 0, len = paths.length; i < len; i++) {
// if (paths[i] === NODE_MODULES_PATH) {
// paths.splice(i, 0, NODE_MODULES_ASAR_PATH);
// break;
// }
// }
// }
//
// return paths;
// };
// ESM-comment-end
};
But going forward, Electron should expose a way for us to enlist a path as ASAR path so that it can internally handle this as early as possible.
The text was updated successfully, but these errors were encountered:
bpasero
added
debt
Code quality issues
electron
Issues and items related to Electron
ESM
Issues caused by our AMD => ESM work
upstream
Issue identified as 'upstream' component related (exists outside of VS Code)
labels
Sep 10, 2024
confirmedIssue has been confirmed by VS Code Team memberdebtCode quality issueselectronIssues and items related to ElectronESMIssues caused by our AMD => ESM workupstreamIssue identified as 'upstream' component related (exists outside of VS Code)
For ESM we have disabled ASAR but we should investigate bringing it back.
We used to have this code to inject the lookup path:
vscode/src/bootstrap-node.js
Lines 210 to 233 in 789c320
But going forward, Electron should expose a way for us to enlist a path as ASAR path so that it can internally handle this as early as possible.
The text was updated successfully, but these errors were encountered: