Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCII characters should not be part of the editing undo/redo stack #229606

Open
rebornix opened this issue Sep 24, 2024 · 1 comment
Open

ASCII characters should not be part of the editing undo/redo stack #229606

rebornix opened this issue Sep 24, 2024 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-edit-context undo-redo Issues around undo/redo

Comments

@rebornix
Copy link
Member

Testing #229383

  • Use Chinese IME on macOS
  • Put cursor in the middle of a document
  • Type nihao, press space to accept
  • With textarea, undo once, all Chinese characters are removed
  • 🐛 With EditContext, undo once, Chinese characters are replaced with nihao, and you can continue to undo each ASCII

Textarea

Screen.Recording.2024-09-24.at.11.57.40.AM.mov

EditContext

Screen.Recording.2024-09-24.at.11.57.06.AM.mov
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Sep 24, 2024
@aiday-mar
Copy link
Contributor

aiday-mar commented Sep 25, 2024

I was able to reproduce, strangely this happens sometimes and other times, Control+Z removes the whole word.
For me it also seems to happen mostly when I type really slowly. If I type ni hao quickly, this does not happen.

After some more investigation I noticed this happens both with the setting and without.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug editor-edit-context undo-redo Issues around undo/redo
Projects
None yet
Development

No branches or pull requests

2 participants