Skip to content

Git - Message Box on git commit errors is too short #169871

@KUGA2

Description

@KUGA2

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.74.2
  • OS Version: Windows_NT x64 10.0.19044

Steps to Reproduce:

  1. Create a git commit hook and print some lines in it (e.g. with pre-commit)
  2. Commit a file via the gui "Commit" button
    image
  3. The commit hook fails.
  4. An message box pops up:
    image

This message box has 3 buttons which do work correct. However the text in there is not helpful.
It only shows the first line of the error. In my case this is pretty misleading. The issue is not unstaged files, it is some empty lines!
You can find the real issue with both the "Open Git Log" and the "Show Command Output" button. This is great.

I still think this should not print the first line only. I think it would be best like this:

Git commit failed!  <-- Window headline
-----
Log: 
<A reasonable amount of output lines, maybe 5>
...
-----
[Open Git Log] [Show Complete Command Output] [Cancel]

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable buggitGIT issuespolishCleanup and polish issue

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions