Chat offline welcome view no longer shown

[chrmarti]

Git bisect points at microsoft/vscode-copilot-chat#2310.

We might get stuck waiting at

vscode/src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts

Line 2073 in 58f407a

await this._autoAttachInstructions(requestInputs);

.

Steps:

• Turn off network connection.
• Reload window.
• Start a chat.
• Expected: Getting Chat Ready... to show in the chat view. Eventually the offline welcome view will be shown.
• Actual: No change in the chat view.

Removing "onInstructionsProvider" and "onSkillProvider" from the Chat package.json gets past it which seems to confirm that these are causing it.