Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb missing on read-only documents supplied by debug adapter #62290

Open
gjsjohnmurray opened this issue Oct 31, 2018 · 4 comments
Open
Assignees
Labels
breadcrumbs feature-request Request for new features or functionality
Milestone

Comments

@gjsjohnmurray
Copy link
Contributor

Issue Type: Bug

VS Code version: Code 1.28.2 (7f3ce96, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 10.0.15063

  1. Start debugging something. In my case I am debugging a debug extension written in Typescript, e.g. the mock-debug sample.
  2. Use the Pause button to suspend execution at a point where the debug adapter will supply the (read-only) source for display. In my case it was easy to suspend in async_hooks.js.
  3. Observe that there's no breadcrumb on the loaded document. Toggling breadcrumb on the View menu has no effect.
  4. Set a breakpoint in a source that exists on the local filesystem. Run to that breakpoint and confirm that a breadcrumb appears as expected. Toggling breadcrumb on the View menu works as expected.

Also occurs on current 1.29 Insider. I don't recall if the same problem existed in other breadcrumb-enabled versions (i.e. 1.26+).

@isidorn
Copy link
Contributor

isidorn commented Oct 31, 2018

I can repro, breadcrumbs are not shown for content provided by the debugContentProvider
Forwarding to @jrieken
Is there something special I need to set for the breadcrumbs to be shwon for debug sources?

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues breadcrumbs labels Oct 31, 2018
@isidorn isidorn assigned jrieken and unassigned isidorn Oct 31, 2018
@jrieken jrieken assigned mjbvz and unassigned mjbvz Nov 2, 2018
@jrieken jrieken added the info-needed Issue requires more information from poster label Nov 2, 2018
@jrieken
Copy link
Member

jrieken commented Nov 2, 2018

Is there something special I need to set for the breadcrumbs to be shwon for debug sources?

It depends on the scheme and if it's known by the file system providers - only then we can provide a meaningful path. Are you using virtual documents?

@isidorn
Copy link
Contributor

isidorn commented Nov 2, 2018

I am not sure what is the definition of a virtual document but I am provding the content from memory. You can see a code pointer in my above comment on what I am doing, registering a contentProvider for the scheme debug. When an uri comes with that scheme I provide the content from memory.

@jrieken
Copy link
Member

jrieken commented Nov 2, 2018

Yeah, those we ignore... Today, only schemes that are supported by the file system provider and the untitled scheme are supported, let's see what we can do here...

@jrieken jrieken added feature-request Request for new features or functionality and removed info-needed Issue requires more information from poster debug Debug viewlet, configurations, breakpoints, adapter issues labels Nov 2, 2018
@jrieken jrieken added this to the Backlog milestone Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breadcrumbs feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants