_MvcCopyDependencyFiles Target is showing up on incremental build hot paths

[baronfel]

The _MvcCopyDependencyFiles target does a couple things that make it take more time than necessary:

• The DepsFilePaths Item Group is built up via batching, which is not ideal from a perf perspective
• The Copy Task is invoked with Batching ("%(DepsFilePaths.FullPath)") which invokes the Task onces for each different item. This is very inefficient
  • It's much more efficient to build up item lists for SourceFiles and DestinationFiles input parameters that explicitly map source to destination by matching position, and to alsp specify SkipUnchangedFiles as true to prevent touching the files on every build, which also causes re-work.

This was found as part of a .NET 10-update analysis for the Copilot team. It's important to fix this (and #15295) because these Targets run for test projects, which are at the 'end' of the build - they are the long tail, and any time spent in them directly extends the overall time of the incremental build.

[nohwnd]

@baronfel does this belong to vstest repo? I assume mvc stands for asp.net mvc, and I don't see any action for us.

[baronfel]

Apologies, you're right and I should have raised this at aspnetcore. Sorry, no was on autopilot - I'll make a new one over there and then come back and close this one.

[nohwnd]

No need to apologize, no problem at all.

[baronfel]

Closing as I've now raised dotnet/aspnetcore#64423