Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: CPUID.CPU-Z.ARM64 version 1.01 #135678

Conversation

Exorcism0666
Copy link
Contributor

@Exorcism0666 Exorcism0666 commented Jan 21, 2024

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Internal-Error-NoSupportedArchitectures The test to validate architectures submitted in the manifest failed. labels Jan 21, 2024
@Exorcism0666
Copy link
Contributor Author

For moderators

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

Important

Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください!

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Internal-Error-NoSupportedArchitectures The test to validate architectures submitted in the manifest failed. Needs-Author-Feedback This needs a response from the author. Changes-Requested Changes Requested labels Jan 22, 2024
@Exorcism0666
Copy link
Contributor Author

@wingetbot run

@wingetbot
Copy link
Collaborator

Commenter does not have sufficient privileges for PR 135678

@stephengillie
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephengillie
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Internal-Error-NoSupportedArchitectures The test to validate architectures submitted in the manifest failed. labels Jan 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Internal-Error-NoSupportedArchitectures The test to validate architectures submitted in the manifest failed. labels Feb 13, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Feb 21, 2024
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Feb 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 21, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

(Automated response - build 796.)

@stephengillie
Copy link
Collaborator

Manual Validation ended with: image

Manual validations are on 64-bit OSes, so changing the architecture from x86 to x64 won't impact this, as it's already running on x64. I believe what's needed is to change the architecture to arm or arm64, but then we won't have a pipeline that can validate it.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Feb 25, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Internal-Error-NoSupportedArchitectures The test to validate architectures submitted in the manifest failed. labels Feb 25, 2024
@Exorcism0666 Exorcism0666 requested a review from Trenly February 26, 2024 08:27
@MagicAndre1981
Copy link

@Trenly @stephengillie is there now a arm64 validation pipeline with maybe Win11 24H2? Users of the new Snapdragon X Elite laptops may want to use arm64 version of cpu-z

@stephengillie
Copy link
Collaborator

@ Trenly @ stephengillie is there now a arm64 validation pipeline with maybe Win11 24H2? Users of the new Snapdragon X Elite laptops may want to use arm64 version of cpu-z

Unfortunately not currently, but I'll bring the increasing demand for this architecture to the team.

@stephengillie
Copy link
Collaborator

Hi @MagicAndre1981,

We can only provide pipelines for the images made available to us by DaaS. Unfortunately, they don't currently have any arm nor arm64 images.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 2, 2024
@ItzLevvie
Copy link
Contributor

[Policy] Blocking-Issue

@microsoft-github-policy-service microsoft-github-policy-service bot added the Blocking-Issue Manifest validation is blocked by a known issue. label Sep 7, 2024
@denelon
Copy link
Contributor

denelon commented Dec 18, 2024

I'm going to go ahead and close this since the schema version is pretty far behind. I don't see any reason not to add the arm64 installer to the existing CPUID.CPU-Z package unless the versions are just completely different.

@denelon denelon closed this Dec 18, 2024
@MagicAndre1981
Copy link

I don't see any reason not to add the arm64 installer to the existing CPUID.CPU-Z package unless the versions are just completely different.

the versions are completely different

@denelon
Copy link
Contributor

denelon commented Dec 19, 2024

Bummer :(

I'll reach out to @stephengillie to see if I can find a way for him to validate arm64 packages manually. We're working with the infrastructure team to have support for automated validation. I don't have a date yet, but they know it's both important and urgent.

@denelon
Copy link
Contributor

denelon commented Dec 19, 2024

In the mean time, if you want to create a PR for the latest version of the package using the current schema version and @mention me, I'll attempt to manually validate it.

@stephengillie
Copy link
Collaborator

stephengillie commented Dec 19, 2024

Manifest fields generally stay the same as versions increase - new versions usually add new fields instead of modifying existing ones. So in most cases, just incrementing the ManifestVersion is enough to satisfy the requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. Internal-Error-NoSupportedArchitectures The test to validate architectures submitted in the manifest failed. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: Add ARM64 Version of CPUID.CPU-Z
7 participants