BUG: refs #946. Remove item from folder only requires write permission

on the folder, not admin.

Author: zachmullen

core/controllers/FolderController.php

@@ -324,9 +324,9 @@ public function removeitemAction()
       {
       throw new Zend_Exception("The item doesn't exist.");
       }
-    elseif(!$this->Folder->policyCheck($folder, $this->userSession->Dao, MIDAS_POLICY_ADMIN))
+    elseif(!$this->Folder->policyCheck($folder, $this->userSession->Dao, MIDAS_POLICY_WRITE))
       {
-      throw new Zend_Exception('Admin permission on folder required');
+      throw new Zend_Exception('Write permission on folder required');
       }
     elseif(!$this->Item->policyCheck($item, $this->userSession->Dao, MIDAS_POLICY_ADMIN))
       {

core/public/js/common/common.browser.js

@@ -217,9 +217,10 @@ midas.removeItem = function (id) {
         $.post(json.global.webroot+'/folder/removeitem',
                {folderId: folderId, itemId: id},
                function(data) {
-                   jsonResponse = jQuery.parseJSON(data);
-                   if(jsonResponse==null) {
-                       midas.createNotice('Error',4000);
+                   var jsonResponse = $.parseJSON(data);
+                   if(!jsonResponse) {
+                       $('div.MainDialog').dialog('close');
+                       midas.createNotice('An error occurred, check the error logs', 4000);
                        return;
                    }
                    if(jsonResponse[0]) {