live reload when on an error page

[Nowaker]

Live reload works great until an exception is not raised. When a stacktrace is shown, live reload will no longer reload the page on file change. I have to do that manually by hitting F5 in the browser.

[bhollis]

That makes sense. The error middleware is probably before the LiveReload middleware.

[Nowaker]

I tried putting live reload middleware in front by hacking ::Middleman::Extensions.@_registered but it didn't help. Missing livereload script still doesn't show up on error page. rack-livereload issue? I'd rather you checked if it is or not, you're more competent than me.

BTW, this is what I added to middleman-core/extensions.rb and then made middleman-livereload.rb to use this method. That's not a quality code (duplicates all the code from register) but is a good start in case both adding livereload to front and patching rack-livereload are needed to resolve this issue.

      def registered
        @_registered ||= ActiveSupport::OrderedHash.new
      end

      def register_first(name, namespace=nil, &block)
        return if registered.key?(name.to_sym) &&
        !registered[name.to_sym].is_a?(String)

        old = registered
        reordered = {}
        reordered[name.to_sym] = if block_given?
          block
        elsif namespace
          namespace
        end
        reordered.merge! old

        @_registered = reordered
      end

[tdreyno]

Sounds like this could be fixed by the extension priority ordering in v4, right?

[sandstrom]

I'm doing some issue-gardening 🌿🌷🌾 and came across this issue.

Sorry that this has lingered for quite a while!

Does this work better under v4? If so can we close this issue?

(this repo is maintained by a few people contributing their free time, unfortunately we can't solve every issue on our own, so help from others is needed for some of the more exotic issues that crops up)

[Nowaker]

@sandstrom I'll check how it works in v4. Thanks for a ping.