FROM feat/771-model-select-validation TO development (#779)

* chore: scaffold fix for issue #771 model select validation

* docs: add PRD and ralph prd.json for issue #771 model select validation fix

* Add PRD for model select bug fix (#771) and cloudflared config

* feat: US-001 - Wire SelectModel value into react-hook-form

SelectModel's onModelSelected callback now passes the selected model
value, allowing agent-create-form to sync it to react-hook-form via
form.setValue. This fixes form validation errors when selecting a model.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: im-an-ai-agent <im.an.ai.agent@gmail.com>

* feat: US-002 - Fix model pre-population on assistant edit page

Sync ChatContext model state when loading agent data so SelectModel
displays the agent's saved model. ChatContext and AgentContext each
have separate useModel() instances; the fix bridges them by calling
setModel from ChatContext in the agent data sync useEffect.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: im-an-ai-agent <im.an.ai.agent@gmail.com>

* chore: finish iteration 1

* Remove .fix-771

* frontned build fix

---------

Signed-off-by: im-an-ai-agent <im.an.ai.agent@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: ryaneggz <kre8mymedia@gmail.com>

Author: 3 people

.gitignore

@@ -30,4 +30,5 @@
 .cursor/ralph-config.json
 **/prd.json
 **/progress.txt
-**/.last-branch
+**/.last-branch
+**/.cloudflared/

.ralph/prd.json

@@ -78,7 +78,7 @@ export function AgentCreateForm() {
 		isAgentSelected,
 		updateQueryStateModel,
 	} = useAgentContext();
-	const { toBackendFormat } = useChatContext();
+	const { toBackendFormat, setModel } = useChatContext();
 	const [isEditing, setIsEditing] = useState(!agentId);
 	const [originalAgent, setOriginalAgent] = useState<Agent | null>(null);
 	const [isFullscreenOpen, setIsFullscreenOpen] = useState(false);
@@ -257,6 +257,11 @@ export function AgentCreateForm() {
 		form.setValue("model", agent.model);
 		form.setValue("public", agent.public || false);
 
+		// Sync ChatContext model so SelectModel displays the agent's saved model
+		if (agent.model) {
+			setModel(agent.model);
+		}
+
 		// Determine mode and set values
 		if (
 			(agent.instructions && agent.instructions.length > 0) ||
@@ -677,7 +682,11 @@ export function AgentCreateForm() {
 									<FormControl>
 										<SelectModel
 											disabled={!isEditing}
-											onModelSelected={updateQueryStateModel}
+											onChange={(value) => {
+												setModel(value);
+												form.setValue("model", value);
+												updateQueryStateModel(value);
+											}}
 										/>
 									</FormControl>
 									<FormMessage />

.ralph/progress.txt

@@ -13,11 +13,12 @@ import { SidebarTrigger } from "@/components/ui/sidebar";
 
 function AgentCreatePage() {
 	const { agent, setAgent, useEffectGetAgents } = useAgentContext();
-	const { useListThreadsEffect, messages } = useChatContext();
+	const { useListThreadsEffect, messages, useModelsEffect } = useChatContext();
 	const [activeTab, setActiveTab] = useQueryState("tab");
 	const [, setSearchParams] = useSearchParams();
 
 	useEffectGetAgents();
+	useModelsEffect();
 
 	const handleTabChange = (value: string) => {
 		setActiveTab(value);

frontend/src/components/forms/agents/agent-create-form.tsx

@@ -0,0 +1,80 @@
+# PRD: Fix Model Select on Assistant Create/Edit Pages
+
+## Introduction
+
+The model select component on the assistant create and edit pages is preventing form submission. After merging PR #767, users can no longer create or edit assistants because selecting a model triggers a validation error ("Model must be at least N characters"). This is a regression bug that blocks core functionality.
+
+## Goals
+
+- Fix the model select validation so assistants can be created and edited successfully
+- Ensure the selected model value is correctly passed to the form state
+- Maintain existing model selection UX without regression
+
+## User Stories
+
+### US-001: Investigate model select form binding
+**Description:** As a developer, I need to understand why the model select value isn't satisfying form validation so I can identify the root cause.
+
+**Acceptance Criteria:**
+- [ ] Identify the component(s) responsible for model selection on assistant create/edit pages
+- [ ] Determine what changed in PR #767 that caused the regression
+- [ ] Document the root cause (e.g., value format mismatch, missing onChange handler, schema change)
+
+### US-002: Fix model select form submission on assistant create
+**Description:** As a user, I want to select a model and successfully create an assistant so I can use the platform.
+
+**Acceptance Criteria:**
+- [ ] Navigate to `/assistant/create`, fill in form details, select a model, and click save
+- [ ] Form submits successfully without validation errors
+- [ ] Created assistant has the correct model assigned
+- [ ] Typecheck/lint passes
+- [ ] Verify in browser using agent-browser skill
+
+### US-003: Fix model select form submission on assistant edit
+**Description:** As a user, I want to edit an existing assistant's model and save successfully.
+
+**Acceptance Criteria:**
+- [ ] Navigate to an existing assistant's edit page
+- [ ] Current model is shown as selected
+- [ ] Change the model and save — no validation errors
+- [ ] Updated assistant reflects the new model
+- [ ] Typecheck/lint passes
+- [ ] Verify in browser using agent-browser skill
+
+### US-004: Verify no regression on other form fields
+**Description:** As a user, I want all other assistant form fields to continue working after the fix.
+
+**Acceptance Criteria:**
+- [ ] All other fields on create/edit pages submit correctly
+- [ ] No new console errors or warnings
+- [ ] Typecheck/lint passes
+
+## Functional Requirements
+
+- FR-1: Model select component must pass the selected value in the format expected by form validation schema
+- FR-2: Form validation must accept valid model selections without character-length errors
+- FR-3: Model select must work on both `/assistant/create` and `/assistant/[id]/edit` pages
+- FR-4: Previously saved assistants must display their current model correctly when editing
+
+## Non-Goals
+
+- No changes to the list of available models
+- No redesign of the model select UI
+- No changes to backend model validation
+
+## Technical Considerations
+
+- Regression introduced by PR #767 — review that diff for changes to model select or form schema
+- Check if the model select component is passing an object vs a string value
+- Check form validation schema (likely Zod) for model field constraints
+- Assistant create and edit pages are in the `@frontend` package
+
+## Success Metrics
+
+- Users can create and edit assistants with any available model without validation errors
+- Zero regression on existing assistant form functionality
+
+## Open Questions
+
+- Did PR #767 change the model select component itself, the form schema, or both?
+- Are there any other select components affected by the same issue?

frontend/src/pages/agents/create.tsx

@@ -0,0 +1,57 @@
+# PRD: Fix Model Select Validation on Assistant Create/Edit (#771)
+
+## Introduction
+
+The ModelSelect component on the assistant create and edit pages does not sync its selected value back to the react-hook-form field, causing a validation error ("Model must be at least 2 characters") that prevents form submission. This broke after merging PR #767.
+
+## Goals
+
+- Fix model selection so it writes to the form field and passes validation
+- Ensure both create and edit flows work end-to-end
+- Maintain backward compatibility with all other SelectModel usages (chat, etc.)
+
+## User Stories
+
+### US-001: Wire SelectModel value into react-hook-form
+**Description:** As a user, I want to select a model from the dropdown on the assistant create page and have the form accept my selection without validation errors.
+
+**Acceptance Criteria:**
+- [ ] When a model is selected via SelectModel, the form's `model` field is updated with the selected value
+- [ ] Form validation passes after selecting a model
+- [ ] Clicking Save after filling all required fields (including model) successfully creates the assistant
+- [ ] Typecheck passes
+- [ ] Verify in browser using agent-browser skill: navigate to `/assistant/create`, fill form, select model, submit succeeds
+
+### US-002: Fix model pre-population on assistant edit page
+**Description:** As a user editing an existing assistant, I want to see the currently configured model pre-selected and be able to change it without validation errors.
+
+**Acceptance Criteria:**
+- [ ] When editing an assistant, the SelectModel dropdown shows the assistant's current model as selected
+- [ ] The form's `model` field is populated with the existing model value on load
+- [ ] Changing the model and saving persists the new selection
+- [ ] Typecheck passes
+- [ ] Verify in browser using agent-browser skill: navigate to an existing assistant's edit page, verify model shown, change it, save succeeds
+
+## Functional Requirements
+
+- FR-1: SelectModel must accept a callback or ref that writes the selected value into the parent form's field (e.g., via `form.setValue("model", value)` or a controlled `value`/`onChange` prop pattern)
+- FR-2: The `agent-create-form.tsx` FormField for `model` must sync SelectModel's selection to react-hook-form state
+- FR-3: On edit, `form.setValue("model", agent.model)` must run on load so the field is pre-populated
+
+## Non-Goals
+
+- No changes to the model list or model fetching logic
+- No changes to the assistant API endpoints
+- No refactoring of SelectModel for standalone/non-context usage (that's #772)
+
+## Technical Considerations
+
+- `SelectModel` currently uses `useChatContext()` internally for state — the fix needs to bridge that context state to the form field
+- Simplest approach: add an `onChange` callback prop to `SelectModel` that fires with the selected value, and use it in the form to call `form.setValue("model", selectedValue)`
+- The existing `onModelSelected` callback has no arguments — either extend it or add a new prop
+- Check that the fix works for both create (empty initial) and edit (pre-populated) flows
+
+## Success Metrics
+
+- Users can create and edit assistants with model selection without validation errors
+- No regressions in chat model selector behavior