fix: resolve linter failures (gofmt, gocyclo)

Run gofmt on files with alignment issues and add nolint:gocyclo
directive to TestLoadConfigFromEnv (complexity 31, threshold 30)
matching the existing pattern in TestBuildDatamoverPod.

Refs: #23

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: 2 people

internal/controller/kubevirt_dataupload_controller.go

@@ -1585,10 +1585,10 @@ func (r *KubeVirtDataUploadReconciler) buildDatamoverPodConfig(
 	}
 
 	return &DatamoverPodConfig{
-		Name:                 du.Name, // Used as a prefix for GenerateName
-		Namespace:            vmRef.Namespace,
-		Image:                image,
-		ImagePullPolicy:      pullPolicy,
+		Name:                     du.Name, // Used as a prefix for GenerateName
+		Namespace:                vmRef.Namespace,
+		Image:                    image,
+		ImagePullPolicy:          pullPolicy,
 		BSLProvider:              cfg.Provider,
 		BSLBucket:                cfg.Bucket,
 		BSLPrefix:                cfg.Prefix,
@@ -1599,17 +1599,17 @@ func (r *KubeVirtDataUploadReconciler) buildDatamoverPodConfig(
 		BSLCACert:                cfg.CACert,
 		CredentialSecretName:     cfg.CredentialName,
 		CredentialSecretKey:      cfg.CredentialKey,
-		VMName:               vmRef.Name,
-		VMNamespace:          vmRef.Namespace,
-		CheckpointName:       checkpointName,
-		BackupType:           backupType,
-		VeleroBackupName:     getVeleroBackupName(du),
-		DataUploadName:       du.Name,
-		DataUploadUID:        string(du.UID),
-		VMBName:              vmb.Name,
-		VMBTName:             vmbtName,
-		SourcePVCName:        "", // overridden by handlePrepared with the rebound PVC name
-		Labels:               make(map[string]string),
+		VMName:                   vmRef.Name,
+		VMNamespace:              vmRef.Namespace,
+		CheckpointName:           checkpointName,
+		BackupType:               backupType,
+		VeleroBackupName:         getVeleroBackupName(du),
+		DataUploadName:           du.Name,
+		DataUploadUID:            string(du.UID),
+		VMBName:                  vmb.Name,
+		VMBTName:                 vmbtName,
+		SourcePVCName:            "", // overridden by handlePrepared with the rebound PVC name
+		Labels:                   make(map[string]string),
 	}, nil
 }
 

internal/controller/pod_builder_test.go

@@ -350,32 +350,32 @@ func TestDatamoverPodConfigDefaults(t *testing.T) {
 // insensitive) should produce true; "false" must not.
 func TestS3CompatibleBooleanRoundtrip(t *testing.T) {
 	tests := []struct {
-		name                 string
-		s3ForcePathStyle     string
+		name                  string
+		s3ForcePathStyle      string
 		insecureSkipTLSVerify string
-		wantForcePathStyle   bool
-		wantInsecureSkip     bool
+		wantForcePathStyle    bool
+		wantInsecureSkip      bool
 	}{
 		{
-			name:                 "both true",
-			s3ForcePathStyle:     "true",
+			name:                  "both true",
+			s3ForcePathStyle:      "true",
 			insecureSkipTLSVerify: "true",
-			wantForcePathStyle:   true,
-			wantInsecureSkip:     true,
+			wantForcePathStyle:    true,
+			wantInsecureSkip:      true,
 		},
 		{
-			name:                 "both false (from strconv.FormatBool)",
-			s3ForcePathStyle:     "false",
+			name:                  "both false (from strconv.FormatBool)",
+			s3ForcePathStyle:      "false",
 			insecureSkipTLSVerify: "false",
-			wantForcePathStyle:   false,
-			wantInsecureSkip:     false,
+			wantForcePathStyle:    false,
+			wantInsecureSkip:      false,
 		},
 		{
-			name:                 "both empty",
-			s3ForcePathStyle:     "",
+			name:                  "both empty",
+			s3ForcePathStyle:      "",
 			insecureSkipTLSVerify: "",
-			wantForcePathStyle:   false,
-			wantInsecureSkip:     false,
+			wantForcePathStyle:    false,
+			wantInsecureSkip:      false,
 		},
 	}
 

pkg/uploader/run.go

@@ -136,25 +136,25 @@ func Run(ctx context.Context, logger logr.Logger) error {
 // LoadConfigFromEnv parses environment variables into UploaderConfig.
 func LoadConfigFromEnv() (*UploaderConfig, error) {
 	config := &UploaderConfig{
-		BSLProvider:      os.Getenv(EnvBSLProvider),
-		BSLBucket:        os.Getenv(EnvBSLBucket),
-		BSLPrefix:        os.Getenv(EnvBSLPrefix),
-		BSLRegion:        os.Getenv(EnvBSLRegion),
+		BSLProvider:              os.Getenv(EnvBSLProvider),
+		BSLBucket:                os.Getenv(EnvBSLBucket),
+		BSLPrefix:                os.Getenv(EnvBSLPrefix),
+		BSLRegion:                os.Getenv(EnvBSLRegion),
 		BSLS3URL:                 os.Getenv(EnvBSLS3URL),
 		BSLS3ForcePathStyle:      strings.EqualFold(os.Getenv(EnvBSLS3ForcePathStyle), "true"),
 		BSLInsecureSkipTLSVerify: strings.EqualFold(os.Getenv(EnvBSLInsecureSkipTLSVerify), "true"),
 		BSLCACert:                os.Getenv(EnvBSLCACert),
-		CredentialsFile:  os.Getenv(EnvCredentialsFile),
-		VMName:           os.Getenv(EnvVMName),
-		VMNamespace:      os.Getenv(EnvVMNamespace),
-		CheckpointName:   os.Getenv(EnvCheckpointName),
-		BackupType:       os.Getenv(EnvBackupType),
-		VeleroBackupName: os.Getenv(EnvVeleroBackupName),
-		DataUploadName:   os.Getenv(EnvDataUploadName),
-		DataUploadUID:    os.Getenv(EnvDataUploadUID),
-		VMBName:          os.Getenv(EnvVMBName),
-		VMBTName:         os.Getenv(EnvVMBTName),
-		SourcePVCPath:    os.Getenv(EnvSourcePVCPath),
+		CredentialsFile:          os.Getenv(EnvCredentialsFile),
+		VMName:                   os.Getenv(EnvVMName),
+		VMNamespace:              os.Getenv(EnvVMNamespace),
+		CheckpointName:           os.Getenv(EnvCheckpointName),
+		BackupType:               os.Getenv(EnvBackupType),
+		VeleroBackupName:         os.Getenv(EnvVeleroBackupName),
+		DataUploadName:           os.Getenv(EnvDataUploadName),
+		DataUploadUID:            os.Getenv(EnvDataUploadUID),
+		VMBName:                  os.Getenv(EnvVMBName),
+		VMBTName:                 os.Getenv(EnvVMBTName),
+		SourcePVCPath:            os.Getenv(EnvSourcePVCPath),
 	}
 
 	// Apply defaults

pkg/uploader/run_test.go

@@ -137,6 +137,7 @@ func TestExtractDiskName(t *testing.T) {
 	}
 }
 
+//nolint:gocyclo // Table-driven test with many validation cases
 func TestLoadConfigFromEnv(t *testing.T) {
 	// Save original env and restore after test
 	originalEnv := map[string]string{