Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace axios k8s API client with version imported from @konveyor/lib-ui #1023

Open
mturley opened this issue Sep 24, 2020 · 0 comments
Open

Comments

@mturley
Copy link
Collaborator

mturley commented Sep 24, 2020

In migtools/lib-ui#21, I ported the src/client/* code from this repo over to lib-ui, for reuse in virt-ui. I made some breaking changes to decouple it from mig-ui data structures, and I removed the unit tests and mocks since they were tied to mig-ui stuff, so maybe we should wait until equivalent mocks and tests have been added back to it in lib-ui.

But once that is done, we should be able to import it all as one object from @konveyor/lib-ui/modules/kube-client or individual classes/types directly from @konveyor/lib-ui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant