You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many of the Action Creators are using bad types for their parameters, imported
from ReturnType of the conversion functions. This is incorrect, and instead
they should be using the I variants that are the composite objects that
hold both the Mig object + its references (like Secrets). Usually these types
are found in a types.ts file, although we are inconsistent.
A PR sufficient for closing this issue should ensure that the described types
all exist, follow the same name convention, and that the action creator's
arguments are correctly typed to accept them
Ex: updateCusters: ICluster[] NOT updateClusters: IMigCluster[]
I've just been burned for a few hours trying to debug an issue that would have
been caught immediately by the compiler had I typed this correctly :)
The text was updated successfully, but these errors were encountered:
Many of the Action Creators are using bad types for their parameters, imported
from ReturnType of the conversion functions. This is incorrect, and instead
they should be using the I variants that are the composite objects that
hold both the Mig object + its references (like Secrets). Usually these types
are found in a types.ts file, although we are inconsistent.
A PR sufficient for closing this issue should ensure that the described types
all exist, follow the same name convention, and that the action creator's
arguments are correctly typed to accept them
Ex: updateCusters: ICluster[] NOT updateClusters: IMigCluster[]
I've just been burned for a few hours trying to debug an issue that would have
been caught immediately by the compiler had I typed this correctly :)
The text was updated successfully, but these errors were encountered: