Skip to content

Commit 0c82a2f

Browse files
Merge pull request #184 from Joeavaikath/fix-konflux-version-arg
Rename VERSION to OADP_VERSION in konflux.Dockerfile
2 parents c7db498 + f92b9ef commit 0c82a2f

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

Containerfile.download

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ RUN go mod download && go mod verify
1313

1414
COPY . .
1515

16-
# Version information
17-
ARG VERSION=dev
16+
# Version information (OADP_VERSION avoids collision with Konflux-injected VERSION)
17+
ARG OADP_VERSION=dev
1818
ARG GIT_COMMIT=unknown
1919

2020
# Build release binaries for all platforms as direct executables
@@ -33,7 +33,7 @@ RUN set -e && \
3333
CGO_ENABLED=0 GOOS=$os GOARCH=$arch \
3434
go build -trimpath \
3535
-ldflags="-s -w \
36-
-X github.com/vmware-tanzu/velero/pkg/buildinfo.Version=${VERSION} \
36+
-X github.com/vmware-tanzu/velero/pkg/buildinfo.Version=${OADP_VERSION} \
3737
-X github.com/vmware-tanzu/velero/pkg/buildinfo.GitSHA=${GIT_COMMIT} \
3838
-X github.com/vmware-tanzu/velero/pkg/buildinfo.GitTreeState=clean" \
3939
-o /archives/$output \

konflux.Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_golang_1.25
77
COPY . /workspace
88
WORKDIR /workspace
99

10-
# Version information
11-
ARG VERSION=dev
10+
# Version information (OADP_VERSION avoids collision with Konflux-injected VERSION)
11+
ARG OADP_VERSION=dev
1212
ARG GIT_COMMIT=unknown
1313

1414
# Build release binaries for all platforms (CGO_ENABLED=0 for cross-platform
@@ -27,7 +27,7 @@ RUN set -e && \
2727
CGO_ENABLED=0 GOOS=$os GOARCH=$arch \
2828
go build -trimpath -mod=mod \
2929
-ldflags="-s -w \
30-
-X github.com/vmware-tanzu/velero/pkg/buildinfo.Version=${VERSION} \
30+
-X github.com/vmware-tanzu/velero/pkg/buildinfo.Version=${OADP_VERSION} \
3131
-X github.com/vmware-tanzu/velero/pkg/buildinfo.GitSHA=${GIT_COMMIT} \
3232
-X github.com/vmware-tanzu/velero/pkg/buildinfo.GitTreeState=clean" \
3333
-o /archives/$output \

0 commit comments

Comments
 (0)