Skip to content

Commit 5d08203

Browse files
committed
Hardcode VERSION to oadp-dev for standardised version reporting
Previously VERSION was derived from git tags/describe, which produced opaque commit hashes. Hardcoding to the branch name (oadp-dev) gives users a meaningful version string via `oc oadp version`. Release branches update this value when cut (e.g., oadp-1.6). Signed-off-by: Joseph <jvaikath@redhat.com>
1 parent c548518 commit 5d08203

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

Containerfile.download

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ RUN go mod download && go mod verify
1414
COPY . .
1515

1616
# Version information (OADP_VERSION avoids collision with Konflux-injected VERSION)
17-
ARG OADP_VERSION=dev
17+
ARG OADP_VERSION=oadp-dev
1818
ARG GIT_COMMIT=unknown
1919

2020
# Build release binaries for all platforms as direct executables

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# Variables
66
BINARY_NAME = kubectl-oadp
77
INSTALL_PATH ?= $(HOME)/.local/bin
8-
VERSION ?= $(shell git describe --tags --always --dirty 2>/dev/null || echo "dev")
8+
VERSION ?= oadp-dev
99
VELERO_NAMESPACE ?= openshift-adp
1010
ASSUME_DEFAULT ?= false
1111

0 commit comments

Comments
 (0)