Use slice element pointer in NABSL prompt loop

NicholasYancey · NicholasYancey · commit aaa30cb48e21 · 2026-06-05T10:07:58.000-04:00
diff --git a/cmd/non-admin/backup/create.go b/cmd/non-admin/backup/create.go
@@ -344,8 +344,9 @@ func promptForNABSLSelection(items []nacv1alpha1.NonAdminBackupStorageLocation,
 	}
 
 	fmt.Fprintln(out, "Multiple non-admin backup storage locations found. Select one:")
-	for i, nabsl := range items {
-		fmt.Fprintf(out, "  %d) %s (%s)\n", i+1, nabsl.Name, formatNABSLPhase(&nabsl))
+	for i := range items {
+		nabsl := &items[i]
+		fmt.Fprintf(out, "  %d) %s (%s)\n", i+1, nabsl.Name, formatNABSLPhase(nabsl))
 	}
 
 	reader := bufio.NewReader(in)

Original file line number	Diff line number	Diff line change
`@@ -344,8 +344,9 @@ func promptForNABSLSelection(items []nacv1alpha1.NonAdminBackupStorageLocation,`
`344`	`344`	`}`
`345`	`345`
`346`	`346`	`fmt.Fprintln(out, "Multiple non-admin backup storage locations found. Select one:")`
`347`		`- for i, nabsl := range items {`
`348`		`- fmt.Fprintf(out, " %d) %s (%s)\n", i+1, nabsl.Name, formatNABSLPhase(&nabsl))`
	`347`	`+ for i := range items {`
	`348`	`+ nabsl := &items[i]`
	`349`	`+ fmt.Fprintf(out, " %d) %s (%s)\n", i+1, nabsl.Name, formatNABSLPhase(nabsl))`
`349`	`350`	`}`
`350`	`351`
`351`	`352`	`reader := bufio.NewReader(in)`