Add more tests

Author: migueldeicaza

Tests/SwiftTermTests/KittyKeyboardAppKitReproductionTests.swift

@@ -0,0 +1,88 @@
+//
+//  KittyKeyboardAppKitReproductionTests.swift
+//
+//  AppKit integration coverage for issue #624. Enable this suite with:
+//  RUN_APPKIT_TESTS=1 swift test --filter KittyKeyboardAppKitReproductionTests
+//
+
+#if os(macOS)
+import AppKit
+import Foundation
+import Testing
+@testable import SwiftTerm
+
+private func appKitTestsEnabled() -> Bool {
+    ProcessInfo.processInfo.environment["RUN_APPKIT_TESTS"] == "1"
+}
+
+@Suite(.enabled(if: appKitTestsEnabled()))
+@MainActor
+final class KittyKeyboardAppKitReproductionTests {
+    private final class CapturingDelegate: TerminalViewDelegate {
+        var sent: [UInt8] = []
+
+        func send(source: TerminalView, data: ArraySlice<UInt8>) {
+            sent.append(contentsOf: data)
+        }
+
+        func sizeChanged(source: TerminalView, newCols: Int, newRows: Int) {}
+        func setTerminalTitle(source: TerminalView, title: String) {}
+        func hostCurrentDirectoryUpdate(source: TerminalView, directory: String?) {}
+        func scrolled(source: TerminalView, position: Double) {}
+        func requestOpenLink(source: TerminalView, link: String, params: [String: String]) {}
+        func bell(source: TerminalView) {}
+        func clipboardCopy(source: TerminalView, content: Data) {}
+        func clipboardRead(source: TerminalView) -> Data? { nil }
+        func iTermContent(source: TerminalView, content: ArraySlice<UInt8>) {}
+        func rangeChanged(source: TerminalView, startY: Int, endY: Int) {}
+    }
+
+    private func press(flags: Int,
+                       characters: String,
+                       charactersIgnoringModifiers: String,
+                       keyCode: UInt16) -> [UInt8] {
+        _ = NSApplication.shared
+
+        let view = TerminalView(frame: CGRect(x: 0, y: 0, width: 400, height: 200))
+        let capture = CapturingDelegate()
+        view.terminalDelegate = capture
+        view.feed(text: "\u{1b}[>\(flags)u")
+
+        let window = NSWindow(contentRect: view.frame,
+                              styleMask: [.titled],
+                              backing: .buffered,
+                              defer: false)
+        window.contentView?.addSubview(view)
+        window.makeFirstResponder(view)
+        capture.sent.removeAll()
+
+        let event = NSEvent.keyEvent(
+            with: .keyDown,
+            location: .zero,
+            modifierFlags: [.shift],
+            timestamp: ProcessInfo.processInfo.systemUptime,
+            windowNumber: window.windowNumber,
+            context: nil,
+            characters: characters,
+            charactersIgnoringModifiers: charactersIgnoringModifiers,
+            isARepeat: false,
+            keyCode: keyCode
+        )!
+        view.keyDown(with: event)
+        return capture.sent
+    }
+
+    @Test func reportAlternatesDoesNotConvertTextProducingKeysToCSIU() {
+        for flags in [5, 7] { // disambiguate + reportAlternates, with optional reportEvents
+            #expect(press(flags: flags,
+                          characters: "E",
+                          charactersIgnoringModifiers: "e",
+                          keyCode: 14) == Array("E".utf8))
+            #expect(press(flags: flags,
+                          characters: "é",
+                          charactersIgnoringModifiers: "è",
+                          keyCode: 33) == Array("é".utf8))
+        }
+    }
+}
+#endif

Tests/SwiftTermTests/MacDefaultLinkTests.swift

@@ -0,0 +1,57 @@
+#if os(macOS)
+import Foundation
+import Testing
+
+@testable import SwiftTerm
+
+@Suite("Mac default link handling")
+struct MacDefaultLinkTests {
+    @Test func keepsExplicitURL() throws {
+        let expected = try #require(URL(string: "https://example.com/path"))
+
+        #expect(TerminalView.defaultLinkURL(expected.absoluteString) == expected)
+    }
+
+    @Test func createsFileURLForExistingPathWithSpaces() throws {
+        try withTemporaryFile(named: "file with spaces.txt") { fileURL in
+            #expect(TerminalView.defaultLinkURL(fileURL.path) == fileURL)
+        }
+    }
+
+    @Test func removesLineAndColumnLocation() throws {
+        try withTemporaryFile(named: "source.swift") { fileURL in
+            #expect(TerminalView.defaultLinkURL("\(fileURL.path):42") == fileURL)
+            #expect(TerminalView.defaultLinkURL("\(fileURL.path):42:10") == fileURL)
+        }
+    }
+
+    @Test func keepsExistingFilenameThatEndsWithLocationSyntax() throws {
+        try withTemporaryFile(named: "source.swift:42") { fileURL in
+            #expect(TerminalView.defaultLinkURL(fileURL.path) == fileURL)
+        }
+    }
+
+    @Test func rejectsMissingFile() {
+        let path = FileManager.default.temporaryDirectory
+            .appendingPathComponent(UUID().uuidString)
+            .path
+
+        #expect(TerminalView.defaultLinkURL(path) == nil)
+        #expect(TerminalView.defaultLinkURL("\(path):42:10") == nil)
+    }
+
+    private func withTemporaryFile(
+        named name: String,
+        body: (URL) throws -> Void
+    ) throws {
+        let directory = FileManager.default.temporaryDirectory
+            .appendingPathComponent(UUID().uuidString, isDirectory: true)
+        try FileManager.default.createDirectory(at: directory, withIntermediateDirectories: true)
+        defer { try? FileManager.default.removeItem(at: directory) }
+
+        let fileURL = directory.appendingPathComponent(name)
+        #expect(FileManager.default.createFile(atPath: fileURL.path, contents: Data()))
+        try body(fileURL)
+    }
+}
+#endif