Ignore expires and max_age arguments if passed to Response.delete_cookie (Fixes #323)

Author: miguelgrinberg

src/microdot/microdot.py

@@ -632,9 +632,13 @@ def delete_cookie(self, cookie, **kwargs):
         """Delete a cookie.
 
         :param cookie: The cookie's name.
-        :param kwargs: Any cookie opens and flags supported by
-                       ``set_cookie()`` except ``expires`` and ``max_age``.
+        :param kwargs: Any cookie options and flags supported by
+                       :meth:`set_cookie() <microdot.Response.set_cookie>`.
+                       Values given for ``expires`` and ``max_age`` are
+                       ignored.
         """
+        kwargs.pop('expires', None)
+        kwargs.pop('max_age', None)
         self.set_cookie(cookie, '', expires='Thu, 01 Jan 1970 00:00:01 GMT',
                         max_age=0, **kwargs)
 

src/microdot/session.py

@@ -25,7 +25,10 @@ def delete(self):
 class Session:
     """
     :param app: The application instance.
-    :param key: The secret key, as a string or bytes object.
+    :param secret_key: The secret key, as a string or bytes object.
+    :param cookie_options: A dictionary with cookie options to pass as
+                           arguments to :meth:`Response.set_cookie()
+                           <microdot.Response.set_cookie>`.
     """
     secret_key = None
 

tests/test_microdot.py

@@ -204,9 +204,10 @@ def index(req):
             res.set_cookie('four', '4')
             res.delete_cookie('two', path='/')
             res.delete_cookie('one', path='/bad')
+            res.delete_cookie('five', max_age=123, expires='foo')
             return res
 
-        client = TestClient(app, cookies={'one': '1', 'two': '2'})
+        client = TestClient(app, cookies={'one': '1', 'two': '2', 'five': '5'})
         res = self._run(client.get('/', headers={'Cookie': 'three=3'}))
         self.assertEqual(res.status_code, 200)
         self.assertEqual(res.headers['Content-Type'],