Remove legacy selection infrastructure and dead UI components

- Remove ModeManager (dead modes: deletePolyrhythm, mobileSelection, selectByMouseOver)
- Remove MouseHandler (redundant — SelectionView handles all interactions)
- Remove NoteViewer (unused component — only static getParityClass retained)
- Remove TouchHoldDetector (only referenced by NoteViewer)
- Remove legacy currentTrackSelections/ITrackSelection from SelectionManager
- Remove isSelected(note) — callers use currentSelection directly
- Extract getParityClass from NoteViewer into core/utils.ts
- Add Requisitions notesClicked event for click-to-play audio preview
- Publish selected note IDs from SelectionManager.endSelection
- Clean up ScoreBookUiServices, App.tsx, ArrangementEditControls, SelectionControls
- Fix Minimap and SelectionManager tests for removed dependencies

Signed-off-by: Mike Lischke <mike@lischke-online.de>

Author: mike-lischke

src/App.tsx

@@ -55,16 +55,16 @@ import {
 import type { IArrangementSnapshot } from "./core/types/general.js";
 import { UndoManager } from "./core/UndoManager.js";
 import { convertErrorToString } from "./core/utils.js";
+import { getSharedAudioContext } from "./core/audio-context.js";
 import { ArrangementPlayer } from "./player/ArrangementPlayer.js";
+import { AudioBufferPlayer } from "./player/AudioBufferPlayer.js";
 import type { ScoreBookUiServices } from "./player/types.js";
 import { escapeStack } from "./supplement/EscapeStack.js";
 import { requisitions } from "./supplement/Requisitions.js";
 import { BackendDisconnectedDialog } from "./ui/BackendDisconnectedDialog.js";
 import { BackendSetupDialog } from "./ui/BackendSetupDialog.js";
 import { LoginDialog } from "./ui/LoginDialog.js";
 import { AdminSetupDialog } from "./ui/AdminSetupDialog.js";
-import { ModeManager } from "./ui/ModeManager.js";
-import { MouseHandler } from "./ui/MouseHandler.js";
 import { SelectionManager } from "./ui/SelectionManager.js";
 import { SettingsDialog } from "./ui/SettingsDialog.js";
 import { TutorialWizard } from "./ui/TutorialWizard.js";
@@ -138,8 +138,6 @@ export class App extends UIComponent<{}, IAppState> {
     private arrangementPlayer?: ArrangementPlayer;
     private undoManager?: UndoManager;
 
-    private mouseHandler?: MouseHandler;
-
     private justFinishedEditingTitle = false;
 
     private currentPlayRange?: { startBar: number; endBar: number; };
@@ -167,7 +165,6 @@ export class App extends UIComponent<{}, IAppState> {
         const selectionManager = new SelectionManager();
         this.services = {
             selectionManager,
-            modeManager: new ModeManager(selectionManager),
         };
 
         this.initEventHandlers();
@@ -185,6 +182,7 @@ export class App extends UIComponent<{}, IAppState> {
         requisitions.register("notificationStateChanged", this.handleNotificationStateChanged);
         requisitions.register("backendDisconnected", this.handleBackendDisconnected);
         requisitions.register("authChanged", this.handleAuthChanged);
+        requisitions.register("notesClicked", this.handleNoteClicked);
 
         void this.checkBackendThenInitialize();
     }
@@ -217,6 +215,7 @@ export class App extends UIComponent<{}, IAppState> {
         requisitions.unregister("notificationStateChanged", this.handleNotificationStateChanged);
         requisitions.unregister("backendDisconnected", this.handleBackendDisconnected);
         requisitions.unregister("authChanged", this.handleAuthChanged);
+        requisitions.unregister("notesClicked", this.handleNoteClicked);
     }
 
     public render() {
@@ -743,6 +742,33 @@ export class App extends UIComponent<{}, IAppState> {
         return Promise.resolve(true);
     };
 
+    private handleNoteClicked = (noteIds: number[]): Promise<boolean> => {
+        const arrangement = this.dataModel.arrangement;
+        if (!arrangement || noteIds.length === 0) {
+            return Promise.resolve(false);
+        }
+
+        const noteId = noteIds[0];
+
+        for (const track of arrangement.tracks) {
+            for (const measure of track.measures) {
+                const event = measure.events.find((e) => {
+                    return e.id === noteId;
+                });
+
+                if (event?.audioData?.audioBuffer) {
+                    const volume = arrangement.mainVolume / 100;
+
+                    new AudioBufferPlayer(event.audioData.audioBuffer, getSharedAudioContext(), 0, volume);
+
+                    return Promise.resolve(true);
+                }
+            }
+        }
+
+        return Promise.resolve(false);
+    };
+
     /**
      * Handles the result of a login dialog show() call for non-pipeline paths.
      *
@@ -1458,8 +1484,6 @@ export class App extends UIComponent<{}, IAppState> {
         window.addEventListener("keyup", (event) => {
             this.handleKeyUp(event);
         });
-
-        this.mouseHandler = new MouseHandler(this.services.modeManager, this.services.selectionManager);
     }
 
     private onSidebarEscape = (): void => {
@@ -1479,13 +1503,11 @@ export class App extends UIComponent<{}, IAppState> {
             case "Escape": {
                 Overlay.closeAllOverlays();
                 this.services.selectionManager.clearSelection();
-                this.services.modeManager.deletePolyrhythmMode = false;
 
                 break;
             }
 
             case "Alt": {
-                this.services.modeManager.deletePolyrhythmMode = true;
                 event.preventDefault();
 
                 break;
@@ -1497,7 +1519,7 @@ export class App extends UIComponent<{}, IAppState> {
                     this.undoManager?.edit({
                         type: "EditCommand_ArrangementClearSelection",
                         arrangement: this.dataModel.arrangement!,
-                        clearSelection: this.services.selectionManager.currentTrackSelections
+                        clearSelection: new Map()
                     });
                     this.services.selectionManager.clearSelection();
                 }
@@ -1535,9 +1557,7 @@ export class App extends UIComponent<{}, IAppState> {
     }
 
     private handleKeyUp(event: KeyboardEvent): void {
-        if (event.key === "Alt") {
-            this.services.modeManager.deletePolyrhythmMode = false;
-        }
+        // No-op: previously reset deletePolyrhythmMode on Alt key up.
     }
 
     private onEditEnd = () => {

src/components/ui/Arrangement/ArrangementEditControls.tsx

@@ -41,7 +41,7 @@ export class ArrangementEditControls
     }
 
     public override componentDidMount(): void {
-        const { dataModel, services } = this.props;
+        const { dataModel } = this.props;
         const { arePolyrhythms } = this.state;
 
         const arrangement = dataModel.arrangement!;
@@ -57,7 +57,6 @@ export class ArrangementEditControls
         const hasPolyrhythms = this.hasPolyrhythms(arrangement);
         if (!hasPolyrhythms) {
             Overlay.toggleOverlay("delete_polyrhythms", "hide");
-            services.modeManager.deletePolyrhythmMode = false;
         }
 
         if (arePolyrhythms !== hasPolyrhythms) {
@@ -79,7 +78,6 @@ export class ArrangementEditControls
         const { arePolyrhythms } = this.state;
 
         const arrangementView = dataModel.arrangement!;
-        const modeManager = services.modeManager;
 
         // TODO: move this to a score creation dialog. Changing that in an existing score makes no sense.
         /*const signatureSelect = (
@@ -119,7 +117,6 @@ export class ArrangementEditControls
                         <>
                             <Button
                                 onClick={() => {
-                                    modeManager.deletePolyrhythmMode = true;
                                     Overlay.toggleOverlay("delete_polyrhythms", "show");
                                 }}
                             >Delete polyrhythms...</Button>
@@ -168,7 +165,7 @@ export class ArrangementEditControls
                         <ExpandingSpacer />
                         <Button
                             onClick={() => {
-                                return modeManager.deletePolyrhythmMode = false;
+                                Overlay.toggleOverlay("delete_polyrhythms", "hide");
                             }}
                         >
                             Done
@@ -204,7 +201,7 @@ export class ArrangementEditControls
     }
 
     private onArrangementChanged = (arrangementId: number): Promise<boolean> => {
-        const { dataModel, services } = this.props;
+        const { dataModel } = this.props;
         const arrangement = dataModel.arrangement!;
 
         if (arrangementId !== arrangement.id) {
@@ -214,8 +211,6 @@ export class ArrangementEditControls
         const arePolyrhythms = this.hasPolyrhythms(arrangement);
         if (!arePolyrhythms) {
             Overlay.toggleOverlay("delete_polyrhythms", "hide");
-
-            services.modeManager.deletePolyrhythmMode = false;
         }
 
         this.setState({ arePolyrhythms });
@@ -247,7 +242,7 @@ export class ArrangementEditControls
     };
 
     private onTrackChanged = (trackId: number): Promise<boolean> => {
-        const { dataModel, services } = this.props;
+        const { dataModel } = this.props;
         const arrangement = dataModel.arrangement!;
 
         // Only react if the changed track is one we care about.
@@ -260,7 +255,6 @@ export class ArrangementEditControls
         const arePolyrhythms = this.hasPolyrhythms(arrangement);
         if (!arePolyrhythms) {
             Overlay.toggleOverlay("delete_polyrhythms", "hide");
-            services.modeManager.deletePolyrhythmMode = false;
         }
 
         this.setState({ arePolyrhythms });
@@ -320,7 +314,7 @@ export class ArrangementEditControls
         const { services } = this.props;
 
         const selectionManager = services.selectionManager;
-        Overlay.toggleOverlay("selection_controls", selectionManager.currentTrackSelections.size ? "show" : "hide");
+        Overlay.toggleOverlay("selection_controls", selectionManager.currentSelection.size ? "show" : "hide");
 
         return Promise.resolve(true);
     };

src/components/ui/GuideRail/TimingViewer.tsx

@@ -8,7 +8,7 @@ import type { ComponentChild } from "preact";
 import type { ITiming } from "../../../core/ScoreBookDataModel.js";
 import type { ITimeParams } from "../../../core/types/general.js";
 import { UIComponent, type ICommonUIProperties } from "../framework/UIComponent.js";
-import { NoteViewer } from "../Note/NoteViewer.js";
+import { getParityClass } from "../../../core/utils.js";
 import { type BarDivisibility } from "./GuideRail.js";
 import { Container } from "../framework/Container.js";
 import { ChildAlignment } from "../framework/ui-types.js";
@@ -32,7 +32,7 @@ export class TimingViewer extends UIComponent<ITimingViewerProperties> {
         const className = this.generateFinalClassName([
             "guiderail-timing",
             "note-width",
-            NoteViewer.getParityClass(bar, step, timeSignature, stepResolution),
+            getParityClass(bar, step, timeSignature, stepResolution),
             this.classFromProperty(isStartOfBar, ["", "startOfBar"])
         ]);