Fix for permission updates of a score lib entry

Signed-off-by: Mike Lischke <mike@lischke-online.de>

Author: mike-lischke

src/core/DatabaseTypes.ts

@@ -3,6 +3,8 @@
  * Licensed under the MIT License. See License.txt in the project root for license information.
  */
 
+import type { ISbDmPermissionInfo } from "./ScoreBookDataModel.js";
+
 /**
  * Types used for database entries.
  */
@@ -15,22 +17,13 @@ export interface ISoundLibFsNode {
     children?: ISoundLibFsNode[];
 }
 
-/** Permission summary for the current user on a score or folder, as returned by the backend. */
-export interface IPermissionDBEntry {
-    isOwner: boolean;
-    canRead: boolean;
-    canWrite: boolean;
-    isWorld: boolean;
-    groupIds: number[];
-}
-
 /** Structure of a score lib folder entry as returned by the REST endpoint. */
 export interface IScoreLibFolderDBEntry {
     id: number;
     parentid: number;
     name: string;
     hasChildren: boolean;
-    perm: IPermissionDBEntry;
+    perm: ISbDmPermissionInfo;
 }
 
 /** Structure of a score lib snippet entry as returned by the REST endpoint. */
@@ -39,7 +32,7 @@ export interface IScoreLibScoreDBEntry {
     folderid: number;
     name: string;
     content: string;
-    perm: IPermissionDBEntry;
+    perm: ISbDmPermissionInfo;
 }
 
 /** Structure of an entry returned by the folder list API. */

src/core/ScoreBookDataModel.ts

@@ -343,7 +343,7 @@ export interface ISbDmVisual extends ISbDmCommon {
     getChildren?(): ScoreBookDataModelEntry[];
 
     /** Permission info for the current user (undefined until the backend provides it). */
-    readonly perm?: ISbDmPermissionInfo;
+    perm?: ISbDmPermissionInfo;
 }
 
 /** Permission summary for the current user on a score or folder. */
@@ -624,21 +624,6 @@ interface IWhoamiResponse {
     capabilities: ICapabilities;
 }
 
-/**
- * Copies permission fields from a source into a target perm object in-place.
- *
- * @param target The existing perm to update.
- * @param source The new perm values to copy.
- */
-const applyPerm = (target: ISbDmPermissionInfo, source: ISbDmPermissionInfo): void => {
-    const t = target as Mutable<ISbDmPermissionInfo>;
-    t.isOwner = source.isOwner;
-    t.canRead = source.canRead;
-    t.canWrite = source.canWrite;
-    t.isWorld = source.isWorld;
-    t.groupIds = source.groupIds;
-};
-
 export class ScoreBookDataModel {
     /**
      * Indicates whether the current session is allowed to mutate scores on the backend.
@@ -1726,10 +1711,10 @@ export class ScoreBookDataModel {
         const newList: Array<ISbDmScoreFolder | ISbDmScore> = [];
 
         data.folders.forEach((folder) => {
-            const existing = existingById.get(folder.id) as ISbDmScoreFolder | undefined;
+            const existing = existingById.get(folder.id);
             if (existing) {
                 existing.name = folder.name;
-                applyPerm(existing.perm!, folder.perm);
+                existing.perm = folder.perm;
                 newList.push(existing);
 
                 return;
@@ -1768,7 +1753,7 @@ export class ScoreBookDataModel {
             if (existing) {
                 existing.name = score.name;
                 existing.content = score.content;
-                applyPerm(existing.perm!, score.perm);
+                existing.perm = score.perm;
                 newList.push(existing);
 
                 return;