Skip to content

Commit 3dfd051

Browse files
authored
[Dashboard] Replace deprecated colors in Borealis (elastic#208473)
## Summary Closes elastic#204590. This replaces the remaining color tokens that were deprecated in the Borealis theme in the Presentation apps. All others are using valid color tokens. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
1 parent d054947 commit 3dfd051

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/platform/plugins/shared/dashboard/public/dashboard_app/top_nav/add_panel_button/components/add_panel_flyout.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,11 +104,11 @@ export function AddPanelFlyout({ dashboardApi }: { dashboardApi: DashboardApi })
104104
position: 'sticky',
105105
top: euiTheme.size.m,
106106
zIndex: 1,
107-
boxShadow: `0 -${euiTheme.size.m} 0 4px ${euiTheme.colors.emptyShade}`,
107+
boxShadow: `0 -${euiTheme.size.m} 0 4px ${euiTheme.colors.backgroundBasePlain}`,
108108
}}
109109
>
110110
<EuiForm component="form" fullWidth>
111-
<EuiFormRow css={{ backgroundColor: euiTheme.colors.emptyShade }}>
111+
<EuiFormRow css={{ backgroundColor: euiTheme.colors.backgroundBasePlain }}>
112112
<EuiFieldSearch
113113
compressed
114114
autoFocus

src/platform/plugins/shared/presentation_util/public/components/dashboard_picker/dashboard_picker.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,9 @@ export function DashboardPicker({ isDisabled, onChange, idsToOmit }: DashboardPi
123123
<EuiText
124124
size="s"
125125
css={css`
126-
color: ${selectedDashboard ? euiTheme.colors.text : euiTheme.colors.disabledText};
126+
color: ${selectedDashboard
127+
? euiTheme.colors.textParagraph
128+
: euiTheme.colors.textDisabled};
127129
`}
128130
>
129131
{selectedDashboard?.label ??

0 commit comments

Comments
 (0)