Skip to content

Commit 8ffa408

Browse files
[Agent Builder] Remove children nav items (elastic#235813)
## Summary - Removes children nav items for Agent Builder <img width="448" height="301" alt="image" src="https://github.com/user-attachments/assets/31b646a4-879c-442f-8522-2b0676bdd8ea" /> - Nav item is also shown as active while on `/agents` and `/tools` <img width="579" height="299" alt="image" src="https://github.com/user-attachments/assets/c1d14b9b-158f-4aaf-bc53-5fc72aa0624b" /> <img width="552" height="301" alt="image" src="https://github.com/user-attachments/assets/2efedc97-f45d-4c1d-851d-0eb2b0801e42" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
1 parent 18d0e54 commit 8ffa408

File tree

4 files changed

+5
-54
lines changed

4 files changed

+5
-54
lines changed

x-pack/solutions/search/plugins/enterprise_search/public/navigation_tree.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -139,25 +139,13 @@ export const getNavigationTreeDefinition = ({
139139
withBadge: true,
140140
},
141141
{
142-
children: [
143-
{ link: 'agent_builder:conversations' },
144-
{ link: 'agent_builder:tools' },
145-
{ link: 'agent_builder:agents' },
146-
],
147-
id: 'agent_builder',
148-
title: AGENTS_TITLE,
149-
renderAs: 'accordion',
142+
link: 'agent_builder',
150143
sideNavVersion: 'v1',
144+
title: AGENTS_TITLE,
151145
},
152146
{
153-
children: [
154-
{ link: 'agent_builder:conversations' },
155-
{ link: 'agent_builder:tools' },
156-
{ link: 'agent_builder:agents' },
157-
],
158147
iconV2: 'comment',
159-
id: 'agent_builder',
160-
renderAs: 'panelOpener',
148+
link: 'agent_builder',
161149
sideNavVersion: 'v2',
162150
title: AGENTS_TITLE,
163151
},

x-pack/solutions/search/plugins/serverless_search/public/navigation_tree.ts

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -112,29 +112,12 @@ export const navigationTree = ({ isAppRegistered }: ApplicationStart): Navigatio
112112
},
113113
{
114114
title: AGENTS_TITLE,
115-
renderAs: 'accordion',
116-
children: [
117-
{
118-
link: 'agent_builder:conversations',
119-
},
120-
{
121-
link: 'agent_builder:agents',
122-
},
123-
{
124-
link: 'agent_builder:tools',
125-
},
126-
],
115+
link: 'agent_builder',
127116
sideNavVersion: 'v1',
128117
},
129118
{
130-
children: [
131-
{ link: 'agent_builder:conversations' },
132-
{ link: 'agent_builder:tools' },
133-
{ link: 'agent_builder:agents' },
134-
],
135119
iconV2: 'comment',
136-
id: 'agent_builder',
137-
renderAs: 'panelOpener',
120+
link: 'agent_builder',
138121
sideNavVersion: 'v2',
139122
title: AGENTS_TITLE,
140123
},

x-pack/solutions/search/test/functional_search/tests/solution_navigation.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -99,16 +99,6 @@ export default function searchSolutionNavigation({
9999
breadcrumbs: ['Agent Chat'],
100100
pageTestSubject: 'onechatPageConversations',
101101
},
102-
{
103-
link: { deepLinkId: 'agent_builder:tools' },
104-
breadcrumbs: ['Tools'],
105-
pageTestSubject: 'kbnAppWrapper visibleChrome',
106-
},
107-
{
108-
link: { deepLinkId: 'agent_builder:agents' },
109-
breadcrumbs: ['Agents'],
110-
pageTestSubject: 'kbnAppWrapper visibleChrome',
111-
},
112102
{
113103
link: { deepLinkId: 'discover' },
114104
breadcrumbs: ['Discover'],

x-pack/solutions/search/test/serverless/functional/test_suites/navigation.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,16 +68,6 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
6868
breadcrumbs: ['Agent Chat'],
6969
pageTestSubject: 'onechatPageConversations',
7070
},
71-
{
72-
link: { deepLinkId: 'agent_builder:tools' },
73-
breadcrumbs: ['Tools'],
74-
pageTestSubject: 'kbnAppWrapper visibleChrome',
75-
},
76-
{
77-
link: { deepLinkId: 'agent_builder:agents' },
78-
breadcrumbs: ['Agents'],
79-
pageTestSubject: 'kbnAppWrapper visibleChrome',
80-
},
8171
{
8272
link: { deepLinkId: 'discover' },
8373
breadcrumbs: ['Discover'],

0 commit comments

Comments
 (0)