Skip to content

Commit c9b32ff

Browse files
authored
[Discover] Fix flaky test elastic#217012 (elastic#218021)
## Summary Flaky test runner x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8175. Resolves elastic#217012. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
1 parent e09548e commit c9b32ff

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/platform/test/functional/apps/discover/group1/_discover_accessibility.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
5050
await kibanaServer.savedObjects.clean({ types: ['search', 'index-pattern'] });
5151
});
5252

53-
// FLAKY: https://github.com/elastic/kibana/issues/217012
54-
describe.skip('top nav menu buttons', () => {
53+
describe('top nav menu buttons', () => {
5554
const focusAndPressButton = async (buttonTestSubject: string | WebElementWrapper) => {
5655
const button =
5756
typeof buttonTestSubject === 'string'
@@ -68,7 +67,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
6867
await retry.try(async () => {
6968
expect(await hasFocus(menuButtonTestSubject)).to.be(false);
7069
});
71-
70+
// Small delay to allow the overlay to open fully
71+
await new Promise((resolve) => setTimeout(resolve, 500));
7272
await browser.pressKeys(browser.keys.ESCAPE);
7373
await retry.try(async () => {
7474
expect(await hasFocus(menuButtonTestSubject)).to.be(true);

0 commit comments

Comments
 (0)