Skip to content

Commit dd0cd38

Browse files
[Dataset Quality] Missed removing skip post fix (elastic#231442)
## Summary related to - elastic#194575 The test was fixed [here](elastic@036f35e), but the skip removal was missed ------------------------- related to -elastic#194599 The test was fixed [here](https://github.com/elastic/kibana/pull/194709/files), but the skip removal was missed
1 parent 5d82874 commit dd0cd38

File tree

2 files changed

+35
-23
lines changed

2 files changed

+35
-23
lines changed

x-pack/solutions/observability/test/serverless/api_integration/test_suites/dataset_quality_api_integration/data_stream_details.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ export default function ({ getService }: DatasetQualityFtrContextProvider) {
4646
});
4747
}
4848

49-
// Failing: See https://github.com/elastic/kibana/issues/194599
50-
describe.skip('gets the data stream details', () => {
49+
describe('gets the data stream details', () => {
5150
let roleAuthc: RoleCredentials;
5251
let internalReqHeader: InternalRequestHeader;
5352

x-pack/solutions/observability/test/serverless/functional/test_suites/dataset_quality/dataset_quality_details.ts

Lines changed: 34 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
5959
const degradedDataStreamName = `logs-${degradedDatasetName}-${defaultNamespace}`;
6060

6161
describe('Dataset quality details', function () {
62-
// see details: https://github.com/elastic/kibana/issues/206734
63-
6462
before(async () => {
6563
// Install Apache Integration and ingest logs for it
6664
await PageObjects.observabilityLogsExplorer.installPackage(apachePkg);
@@ -169,25 +167,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
169167
});
170168
});
171169

172-
// FLAKY: https://github.com/elastic/kibana/issues/194575
173-
describe.skip('overview summary panel', () => {
174-
it('should show summary KPIs', async () => {
175-
await PageObjects.datasetQuality.navigateToDetails({
176-
dataStream: apacheAccessDataStreamName,
177-
});
178-
179-
const { docsCountTotal, degradedDocs, services, hosts, size } =
180-
await PageObjects.datasetQuality.parseOverviewSummaryPanelKpis();
181-
expect(parseInt(docsCountTotal, 10)).to.be(226);
182-
expect(parseInt(degradedDocs, 10)).to.be(1);
183-
expect(parseInt(services, 10)).to.be(3);
184-
expect(parseInt(hosts, 10)).to.be(52);
185-
// metering stats API is cached for 30seconds, waiting for the exact value is not optimal in this case
186-
// rather we can just check if any value is present
187-
expect(size).to.be.ok();
188-
});
189-
});
190-
191170
describe('overview integrations', () => {
192171
it('should hide the integration section for non integrations', async () => {
193172
await PageObjects.datasetQuality.navigateToDetails({
@@ -476,5 +455,39 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
476455
expect(singleValueNow).to.be.greaterThan(singleValuePreviously);
477456
});
478457
});
458+
459+
describe('overview summary panel', () => {
460+
it('should show summary KPIs', async () => {
461+
await PageObjects.datasetQuality.navigateToDetails({
462+
dataStream: apacheAccessDataStreamName,
463+
});
464+
465+
const { docsCountTotal, degradedDocs, services, hosts } =
466+
await PageObjects.datasetQuality.parseOverviewSummaryPanelKpis(['size']);
467+
expect(parseInt(docsCountTotal, 10)).to.be(226);
468+
expect(parseInt(degradedDocs, 10)).to.be(1);
469+
expect(parseInt(services, 10)).to.be(3);
470+
expect(parseInt(hosts, 10)).to.be(52);
471+
});
472+
473+
// this test must always stay at the last because here we log the user in as admin.
474+
// We need admin priviledge for the `size` attribute to be present in the summary panel.
475+
it('should show summary panel with size attributte for admin role only', async () => {
476+
await PageObjects.svlCommonPage.loginAsAdmin();
477+
await PageObjects.datasetQuality.navigateToDetails({
478+
dataStream: apacheAccessDataStreamName,
479+
});
480+
481+
const { docsCountTotal, degradedDocs, services, hosts, size } =
482+
await PageObjects.datasetQuality.parseOverviewSummaryPanelKpis();
483+
expect(parseInt(docsCountTotal, 10)).to.be(226);
484+
expect(parseInt(degradedDocs, 10)).to.be(1);
485+
expect(parseInt(services, 10)).to.be(3);
486+
expect(parseInt(hosts, 10)).to.be(52);
487+
// metering stats API is cached for 30seconds, waiting for the exact value is not optimal in this case
488+
// rather we can just check if any value is present
489+
expect(size).to.be.ok();
490+
});
491+
});
479492
});
480493
}

0 commit comments

Comments
 (0)