Skip to content

Commit fd18951

Browse files
agusruidiazgdelasticmachinekapral18
authored
[SecuritySolution] Numbers of Network KPI metric are cropped (elastic#211460)
## Summary Fix issue elastic#210806 ### Network Page | Before | After | |--------|-------| | ![Network Before](https://github.com/user-attachments/assets/0b3277f7-dbe2-41a4-ac76-05a806bb42e8) | ![Network After](https://github.com/user-attachments/assets/12b16e81-d13b-495f-9d46-a4154aa8e0cf) | ### Host Page | Before | After | |--------|-------| | ![Host Before](https://github.com/user-attachments/assets/1338b0e5-f4b1-4d1a-ad54-da392f0eff07) | ![Host After](https://github.com/user-attachments/assets/48af01d9-a4aa-450d-ac81-e2b4a724363f) | ### Users Page | Before | After | |--------|-------| | ![Users Before](https://github.com/user-attachments/assets/d7acdf4d-9a4f-4b67-923c-a184e13b367f) | ![Users After](https://github.com/user-attachments/assets/43bf36bd-1e3b-47d7-b121-0d4142b18cbe) | ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Karen Grigoryan <[email protected]>
1 parent 04a9acd commit fd18951

File tree

10 files changed

+12
-21
lines changed

10 files changed

+12
-21
lines changed

x-pack/solutions/security/plugins/security_solution/public/common/components/visualization_actions/lens_attributes/network/__snapshots__/kpi_dns_queries.test.ts.snap

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/solutions/security/plugins/security_solution/public/common/components/visualization_actions/lens_attributes/network/__snapshots__/kpi_network_events.test.ts.snap

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/solutions/security/plugins/security_solution/public/common/components/visualization_actions/lens_attributes/network/__snapshots__/kpi_tls_handshakes.test.ts.snap

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/solutions/security/plugins/security_solution/public/common/components/visualization_actions/lens_attributes/network/__snapshots__/kpi_unique_flow_ids.test.ts.snap

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/solutions/security/plugins/security_solution/public/common/components/visualization_actions/lens_attributes/network/kpi_dns_queries.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const kpiDnsQueriesLensAttributes: LensAttributes = {
1717
accessor: '0374e520-eae0-4ac1-bcfe-37565e7fc9e3',
1818
layerType: 'data',
1919
colorMode: 'None',
20-
autoScaleMetricAlignment: 'left',
20+
autoScaleMetricAlignment: 'center',
2121
},
2222
query: {
2323
query: '',

x-pack/solutions/security/plugins/security_solution/public/common/components/visualization_actions/lens_attributes/network/kpi_network_events.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export const kpiNetworkEventsLensAttributes: LensAttributes = {
1616
layerId: 'eaadfec7-deaa-4aeb-a403-3b4e516416d2',
1717
accessor: '370ebd07-5ce0-4f46-a847-0e363c50d037',
1818
layerType: 'data',
19-
autoScaleMetricAlignment: 'left',
19+
autoScaleMetricAlignment: 'center',
2020
},
2121
query: {
2222
query: '',

x-pack/solutions/security/plugins/security_solution/public/common/components/visualization_actions/lens_attributes/network/kpi_tls_handshakes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export const kpiTlsHandshakesLensAttributes: LensAttributes = {
1515
layerId: '1f48a633-8eee-45ae-9471-861227e9ca03',
1616
accessor: '21052b6b-5504-4084-a2e2-c17f772345cf',
1717
layerType: 'data',
18-
autoScaleMetricAlignment: 'left',
18+
autoScaleMetricAlignment: 'center',
1919
},
2020
query: {
2121
query:

x-pack/solutions/security/plugins/security_solution/public/common/components/visualization_actions/lens_attributes/network/kpi_unique_flow_ids.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export const kpiUniqueFlowIdsLensAttributes: LensAttributes = {
1616
layerId: '5d46d48f-6ce8-46be-a797-17ad50642564',
1717
accessor: 'a27f3503-9c73-4fc1-86bb-12461dae4b70',
1818
layerType: 'data',
19-
autoScaleMetricAlignment: 'left',
19+
autoScaleMetricAlignment: 'center',
2020
},
2121
query: {
2222
query: 'source.ip: * or destination.ip: * ',

x-pack/solutions/security/plugins/security_solution/public/explore/components/stat_items/metric_embeddable.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
* 2.0; you may not use this file except in compliance with the Elastic License
55
* 2.0.
66
*/
7-
import { EuiFlexGroup, EuiIcon } from '@elastic/eui';
7+
import { EuiFlexGroup, EuiFlexItem, EuiIcon } from '@elastic/eui';
88
import React from 'react';
9-
import { FlexItem, MetricItem, StatValue } from './utils';
9+
import { FlexItem, StatValue } from './utils';
1010
import { VisualizationEmbeddable } from '../../../common/components/visualization_actions/visualization_embeddable';
1111
import type { FieldConfigs } from './types';
1212

@@ -41,7 +41,7 @@ const MetricEmbeddableComponent = ({
4141
</FlexItem>
4242
)}
4343

44-
<MetricItem>
44+
<EuiFlexItem>
4545
{field.lensAttributes && (
4646
<div data-test-subj="stat-title">
4747
<VisualizationEmbeddable
@@ -54,7 +54,7 @@ const MetricEmbeddableComponent = ({
5454
/>
5555
</div>
5656
)}
57-
</MetricItem>
57+
</EuiFlexItem>
5858
{field.description != null && (
5959
<FlexItem>
6060
<StatValue>

x-pack/solutions/security/plugins/security_solution/public/explore/components/stat_items/utils.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,6 @@ export const FlexItem = styled(EuiFlexItem)`
2424

2525
FlexItem.displayName = 'FlexItem';
2626

27-
export const MetricItem = styled(EuiFlexItem)`
28-
&.euiFlexItem {
29-
flex-basis: 0;
30-
flex-grow: 0;
31-
min-width: 100px;
32-
}
33-
`;
34-
MetricItem.displayName = 'MetricItem';
35-
3627
export const StatValue = styled(EuiTitle)`
3728
overflow: hidden;
3829
text-overflow: ellipsis;

0 commit comments

Comments
 (0)