Skip to content

Tree insideSandbox doesn't account for immediate parent directory #149

@mnutt

Description

@mnutt

At least on node v4/v6, Path.relative returns .. when a directory is compared with its immediate parent. This will cause insideSandbox to return true even though the parent isn't inside the sandbox, since it's looking for ../. I think this can be fixed by just comparing against .. instead; I can't think of any situations where that would cause issues.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions