Fix that Message#attachemnts cannot count singlepart attachment

Author: kirikak2

CHANGELOG.rdoc

@@ -58,6 +58,7 @@ Bugs:
 * #1110 - Fix that Mail::Multibyte::Chars#initialize mutated its argument by calling force_encoding on it. (jeremy)
 * #1113 - Eliminate attachment corruption caused by CRLF conversion. (jeremy)
 * #1131 - Fix that Message#without_attachments! didn't parse the remaining parts. (jeremy)
+* #1143 - Fix that Message#attachment cannot count singlepart attachment. (kirikak2)
 
 == Version 2.6.4 - Wed Mar 23 08:16 -0700 2016 Jeremy Daer <[email protected]>
 

lib/mail/attachments_list.rb

@@ -2,11 +2,13 @@
 module Mail
   class AttachmentsList < Array
 
-    def initialize(parts_list)
+    def initialize(body_attachment = nil, parts_list)
       @parts_list = parts_list
       @content_disposition_type = 'attachment'
-      parts_list.map { |p|
-        if p.mime_type == 'message/rfc822'
+      [body_attachment].concat(parts_list).map { |p|
+        if p.nil?
+          nil
+        elsif p.mime_type == 'message/rfc822'
           Mail.new(p.body.encoded).attachments
         elsif p.parts.empty?
           p if p.attachment?

lib/mail/message.rb

@@ -1655,7 +1655,11 @@ def parts
     #  mail.attachments[0]                #=> Mail::Part (first attachment)
     #
     def attachments
-      parts.attachments
+      if !multipart? && attachment? && !self.instance_of?(Mail::Part)
+        parts.attachments(generate_attachment_part_from_body)
+      else
+        parts.attachments
+      end
     end
 
     def has_attachments?
@@ -2167,5 +2171,19 @@ def do_delivery
     def decode_body_as_text
       Encodings.transcode_charset decode_body, charset, 'UTF-8'
     end
+
+    def generate_attachment_part_from_body
+      part = Mail::Part.new(nil)
+      header_part = []
+      header_part << header[:content_type].encoded if header[:content_type]
+      header_part << header[:content_disposition].encoded if header[:content_disposition]
+      header_part << header[:content_transfer_encoding].encoded if header[:content_transfer_encoding]
+      header_part << header[:content_discription].encoded if header[:content_discription]
+      part.header = header_part.join
+      unless @body.nil?
+        part.body = @body.encoded
+      end
+      part
+    end
   end
 end

lib/mail/parts_list.rb

@@ -21,8 +21,8 @@ def to_yaml(options = {}) # :nodoc:
       @parts.to_yaml(options)
     end
 
-    def attachments
-      Mail::AttachmentsList.new(@parts)
+    def attachments(body_attachment = nil)
+      Mail::AttachmentsList.new(body_attachment, @parts)
     end
 
     def collect

spec/mail/attachments_list_spec.rb

@@ -128,6 +128,16 @@ def check_decoded(actual, expected)
 
   end
 
+  describe "single attachment" do
+    subject{ read_fixture("emails", "attachment_emails", "attachment_only_email.eml") }
+
+    it "should get one attachment from #attachments method" do
+      expect(subject.attachments.length).to eq(1)
+      expect(subject.attachments[0].filename).to eq("blah.gz")
+      expect(subject.attachments[0].decoded).not_to be_nil
+    end
+  end
+
   describe "multiple attachments" do
 
     it "should allow you to pass in more than one attachment" do