Merge pull request #1513 from ahorek/upack1_perf

use unpack1

Author: mikel

lib/mail/encodings/quoted_printable.rb

@@ -16,7 +16,7 @@ def self.can_encode?(enc)
       # Decode the string from Quoted-Printable. Cope with hard line breaks
       # that were incorrectly encoded as hex instead of literal CRLF.
       def self.decode(str)
-        ::Mail::Utilities.to_lf ::Mail::Utilities.to_crlf(str).gsub(/(?:=0D=0A|=0D|=0A)\r\n/, "\r\n").unpack("M*").first
+        ::Mail::Utilities.to_lf ::Mail::Utilities.to_crlf(str).gsub(/(?:=0D=0A|=0D|=0A)\r\n/, "\r\n").unpack1("M*")
       end
 
       def self.encode(str)

lib/mail/encodings/unix_to_unix.rb

@@ -5,7 +5,7 @@ class UnixToUnix < TransferEncoding
       NAME = "x-uuencode"
 
       def self.decode(str)
-        str.sub(/\Abegin \d+ [^\n]*\n/, '').unpack('u').first
+        str.sub(/\Abegin \d+ [^\n]*\n/, '').unpack1('u')
       end
 
       def self.encode(str)

lib/mail/utilities.rb

@@ -363,7 +363,7 @@ def Utilities.decode_base64(str)
       if !str.end_with?("=") && str.length % 4 != 0
         str = str.ljust((str.length + 3) & ~3, "=")
       end
-      str.unpack( 'm' ).first
+      str.unpack1( 'm' )
     end
 
     def Utilities.encode_base64(str)
@@ -399,7 +399,7 @@ def Utilities.encode_utf7(string)
     def Utilities.decode_utf7(utf7)
       utf7.gsub(/&([^-]+)?-/n) do
         if $1
-          ($1.tr(",", "/") + "===").unpack("m")[0].encode(Encoding::UTF_8, Encoding::UTF_16BE)
+          ($1.tr(",", "/") + "===").unpack1("m").encode(Encoding::UTF_8, Encoding::UTF_16BE)
         else
           "&"
         end