Merge pull request #1483 from mikepenz/fix/1471

Allow `includePassed` to work independently of `includePassed`

Author: mikepenz

__tests__/table.test.ts

@@ -216,6 +216,127 @@ describe('buildSummaryTables', () => {
     expect(flakyTable).toStrictEqual(FLAKY_TABLE)
   })
 
+  it('should show skipped tests when includeSkipped=true but includePassed=false', async () => {
+    // This tests the key use case: showing only failed and skipped tests, without passed tests
+    const testResult = await parseTestReports(
+      'checkName',
+      'summary',
+      'test_results/tests/utils/target/surefire-reports/TEST-action.surefire.report.calc.StringUtilsTest.xml',
+      '*',
+      true, // Parse all tests
+      true,
+      true,
+      [],
+      undefined,
+      '/'
+    )
+
+    // Build with includePassed=false but includeSkipped=true
+    const [, detailTable] = buildSummaryTables(
+      [testResult],
+      false, // includePassed - don't show passed tests
+      true,  // includeSkipped - but DO show skipped tests
+      true,  // detailedSummary
+      false, // flakySummary
+      false, // verboseSummary
+      false  // skipSuccessSummary
+    )
+
+    const flatResults = detailTable.flat()
+
+    // Should include skipped tests
+    const hasSkippedTests = flatResults.some(cell => typeof cell === 'string' && cell.includes('⚠️ skipped'))
+    expect(hasSkippedTests).toBe(true)
+
+    // Should include failed tests
+    const hasFailedTests = flatResults.some(cell => typeof cell === 'string' && cell.includes('❌ failure'))
+    expect(hasFailedTests).toBe(true)
+
+    // Should NOT include passed tests
+    const hasPassedTests = flatResults.some(cell => typeof cell === 'string' && cell.includes('✅ passed'))
+    expect(hasPassedTests).toBe(false)
+  })
+
+  it('should hide both passed and skipped when both include flags are false', async () => {
+    const testResult = await parseTestReports(
+      'checkName',
+      'summary',
+      'test_results/tests/utils/target/surefire-reports/TEST-action.surefire.report.calc.StringUtilsTest.xml',
+      '*',
+      true, // Parse all tests
+      true,
+      true,
+      [],
+      undefined,
+      '/'
+    )
+
+    // Build with both includePassed=false and includeSkipped=false
+    const [, detailTable] = buildSummaryTables(
+      [testResult],
+      false, // includePassed - don't show passed tests
+      false, // includeSkipped - don't show skipped tests either
+      true,  // detailedSummary
+      false, // flakySummary
+      false, // verboseSummary
+      false  // skipSuccessSummary
+    )
+
+    const flatResults = detailTable.flat()
+
+    // Should NOT include skipped tests
+    const hasSkippedTests = flatResults.some(cell => typeof cell === 'string' && cell.includes('⚠️ skipped'))
+    expect(hasSkippedTests).toBe(false)
+
+    // Should include failed tests
+    const hasFailedTests = flatResults.some(cell => typeof cell === 'string' && cell.includes('❌ failure'))
+    expect(hasFailedTests).toBe(true)
+
+    // Should NOT include passed tests
+    const hasPassedTests = flatResults.some(cell => typeof cell === 'string' && cell.includes('✅ passed'))
+    expect(hasPassedTests).toBe(false)
+  })
+
+  it('should show both passed and skipped when both include flags are true', async () => {
+    const testResult = await parseTestReports(
+      'checkName',
+      'summary',
+      'test_results/tests/utils/target/surefire-reports/TEST-action.surefire.report.calc.StringUtilsTest.xml',
+      '*',
+      true, // Parse all tests
+      true,
+      true,
+      [],
+      undefined,
+      '/'
+    )
+
+    // Build with both includePassed=true and includeSkipped=true
+    const [, detailTable] = buildSummaryTables(
+      [testResult],
+      true,  // includePassed - show passed tests
+      true,  // includeSkipped - show skipped tests
+      true,  // detailedSummary
+      false, // flakySummary
+      false, // verboseSummary
+      false  // skipSuccessSummary
+    )
+
+    const flatResults = detailTable.flat()
+
+    // Should include skipped tests
+    const hasSkippedTests = flatResults.some(cell => typeof cell === 'string' && cell.includes('⚠️ skipped'))
+    expect(hasSkippedTests).toBe(true)
+
+    // Should include failed tests
+    const hasFailedTests = flatResults.some(cell => typeof cell === 'string' && cell.includes('❌ failure'))
+    expect(hasFailedTests).toBe(true)
+
+    // Should include passed tests
+    const hasPassedTests = flatResults.some(cell => typeof cell === 'string' && cell.includes('✅ passed'))
+    expect(hasPassedTests).toBe(true)
+  })
+
   it('should include flaky tests in summary even when includePassed is false', async () => {
     const testResult = await parseTestReports(
       'checkName',

dist/index.js

@@ -93,7 +93,7 @@ export function buildSummaryTables(
 
     const annotations = testResult.globalAnnotations.filter(
       annotation =>
-        (includePassed || annotation.annotation_level !== 'notice' || annotation.retries > 0) &&
+        (includePassed || annotation.status !== 'success' || annotation.retries > 0) &&
         (includeSkipped || annotation.status !== 'skipped')
     )
 
@@ -112,7 +112,8 @@ export function buildSummaryTables(
         if (!groupSuite) {
           for (const annotation of annotations) {
             // Skip passed tests (including flaky ones) in details table when includePassed is false
-            if (!includePassed && annotation.annotation_level === 'notice') {
+            // Note: skipped tests have status='skipped' and are handled separately by includeSkipped
+            if (!includePassed && annotation.status === 'success') {
               continue
             }
             const detailsRow = [
@@ -174,9 +175,10 @@ function appendDetailsTable(
 ): void {
   const colspan = includeTimeInSummary ? '3' : '2'
   // For details table, don't include passed tests when includePassed is false (even if flaky)
+  // Note: skipped tests have status='skipped' and are handled separately by includeSkipped
   const annotations = testResult.annotations.filter(
     annotation =>
-      (includePassed || annotation.annotation_level !== 'notice') &&
+      (includePassed || annotation.status !== 'success') &&
       (includeSkipped || annotation.status !== 'skipped')
   )
   if (annotations.length > 0) {