-
Notifications
You must be signed in to change notification settings - Fork 8
Closed
Description
Lots of dependencies. Are these required?
- Perhaps we can have an optional group for each example? (RL, NLP, Jax, etc)
Weird
[gpu]optional dependency group, why?I think it would be nice to disentangle the dependencies of the template from those of the example projects. Several straightforward reasons:
- I don't like the idea of the template automatically installing packages that only pertain to the examples and I will never use in the project (e.g. I don't use Jax, but even if I toggle off the Jax-related examples the
uvx copiercommand will install Jax in my venv regardless), leading to bloated venvs.- Our own project dependencies etc. may require different versions/combinations of these pre-installed packages.
- The current dependencies make it impossible to use this template locally on a macOS system because the venv creation fails due to incompatibilities wrt Jax & macOS (I believe because
jax-cuda12-pluginis listed as a dependency, the wheels for which of course isn't available on macOS). I understand that this template is mostly intended to be used on the Mila cluster, but I'm just stating it here to demonstrate that installing these example-project-related packages may have some unintended consequences.Having optional groups for dependencies is an excellent idea, but there also needs to be a 'minimal dependency' option where none of the packages associated only with the examples are installed automatically.
Originally posted by @semihcanturk in #77
Metadata
Metadata
Assignees
Labels
No labels